A modern Music Player Daemon based on Rockbox open source high quality audio player
libadwaita audio rust zig deno mpris rockbox mpd

Fix checks on buflib allocated handles (0 is not a valid handle value)

Change-Id: I8fdc5a59a5062f40a431cd49971390e21631b8ec

+7 -7
+1 -1
apps/filetypes.c
··· 344 344 345 345 strdup_bufsize = filesize(fd); 346 346 strdup_handle = core_alloc_ex("filetypes", strdup_bufsize, &ops); 347 - if (strdup_handle < 0) 347 + if (strdup_handle <= 0) 348 348 { 349 349 close(fd); 350 350 return;
+1 -1
apps/gui/icon.c
··· 197 197 size_t buf_size = read_bmp_fd(fd, &ic->bmp, 0, 198 198 bmpformat|FORMAT_RETURN_SIZE, NULL); 199 199 ic->handle = core_alloc_ex(filename, buf_size, &buflib_ops); 200 - if (ic->handle < 0) 200 + if (ic->handle <= 0) 201 201 { 202 202 close(fd); 203 203 return;
+1 -1
apps/gui/skin_engine/skin_backdrops.c
··· 245 245 backdrops[i].buflib_handle = 246 246 core_alloc_ex(global_settings.backdrop_file, 247 247 LCD_BACKDROP_BYTES, &buflib_ops); 248 - if (backdrops[i].buflib_handle < 0) 248 + if (backdrops[i].buflib_handle <= 0) 249 249 return; 250 250 } 251 251 bool loaded;
+2 -2
apps/gui/skin_engine/skin_parser.c
··· 1665 1665 size_t buf_size = read_bmp_fd(fd, bitmap, 0, 1666 1666 format|FORMAT_RETURN_SIZE, NULL); 1667 1667 handle = core_alloc_ex(bitmap->data, buf_size, &buflib_ops); 1668 - if (handle < 0) 1668 + if (handle <= 0) 1669 1669 { 1670 1670 DEBUGF("Not enough skin buffer: need %zd more.\n", 1671 1671 buf_size - skin_buffer_freespace()); ··· 2315 2315 #ifndef __PCTOOL__ 2316 2316 wps_data->buflib_handle = core_alloc(isfile ? buf : "failsafe skin", 2317 2317 skin_buffer_usage()); 2318 - if (wps_data->buflib_handle >= 0) 2318 + if (wps_data->buflib_handle > 0) 2319 2319 { 2320 2320 wps_data->wps_loaded = true; 2321 2321 memcpy(core_get_data(wps_data->buflib_handle), skin_buffer,
+1 -1
apps/scrobbler.c
··· 255 255 return -1; 256 256 257 257 scrobbler_cache = core_alloc("scrobbler", SCROBBLER_MAX_CACHE*SCROBBLER_CACHE_LEN); 258 - if (scrobbler_cache < 0) 258 + if (scrobbler_cache <= 0) 259 259 { 260 260 logf("SCROOBLER: OOM"); 261 261 return -1;
+1 -1
firmware/font.c
··· 514 514 int handle = core_alloc_ex( path, 515 515 bufsize + sizeof( struct buflib_alloc_data ), 516 516 &buflibops ); 517 - if ( handle < 0 ) 517 + if ( handle <= 0 ) 518 518 { 519 519 return -1; 520 520 }