appview/knots,spindles: ignore invalid handles when removing members #927

This was preventing knot and spindle owners from removing members if the members's handle became invalid

Fixes: https://tangled.org/tangled.org/core/issues/192

-10

2 changed files

Diff round #1

expand all

unified split

appview

knots

knots.go

spindles

spindles.go

-5

appview/knots/knots.go

··· 666 k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 667 return 668 } 669 - if memberId.Handle.IsInvalidHandle() { 670 - l.Error("failed to resolve member identity to handle") 671 - k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 672 - return 673 - } 674 675 // remove from enforcer 676 err = k.Enforcer.RemoveKnotMember(domain, memberId.DID.String())

··· 666 k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 667 return 668 } 669 670 // remove from enforcer 671 err = k.Enforcer.RemoveKnotMember(domain, memberId.DID.String())

-5

appview/spindles/spindles.go

··· 653 s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 654 return 655 } 656 - if memberId.Handle.IsInvalidHandle() { 657 - l.Error("failed to resolve member identity to handle") 658 - s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 659 - return 660 - } 661 662 tx, err := s.Db.Begin() 663 if err != nil {

··· 653 s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 654 return 655 } 656 657 tx, err := s.Db.Begin() 658 if err != nil {

History

2 rounds 2 comments

yemou.pink submitted #1 2mo

interdiff

1 commit

expand

ffe32bbc

appview/knots,spindles: ignore invalid handles when removing members

expand 1 comment

oppi.li 2mo

lgtm! thanks for the contribution.

pull request successfully merged

yemou.pink submitted #0 2mo

diff

1 commit

expand

f0df8870

appview/knots,spindles: ignore invalid handles when removing members

expand 1 comment

yemou.pink 2mo

I made a mistake here