appview/knots,spindles: ignore invalid handles when removing members #927

This was preventing knot and spindle owners from removing members if the members's handle became invalid

Fixes: https://tangled.org/tangled.org/core/issues/192

+5 -5

2 changed files

Interdiff #0 → #1

expand all

unified split

appview

knots

knots.go

spindles

spindles.go

appview/knots/knots.go

This file has not been changed.

+5 -5

appview/spindles/spindles.go

··· 523 s.Pages.Notice(w, noticeId, "Failed to add member, identity resolution failed.") 524 return 525 } 526 527 // write to pds 528 client, err := s.OAuth.AuthorizedClient(r) ··· 645 646 647 648 - s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 649 - return 650 - } 651 - if memberId.Handle.IsInvalidHandle() { 652 - l.Error("failed to resolve member identity to handle") 653 s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 654 return 655 }

··· 523 s.Pages.Notice(w, noticeId, "Failed to add member, identity resolution failed.") 524 return 525 } 526 + if memberId.Handle.IsInvalidHandle() { 527 + l.Error("failed to resolve member identity to handle") 528 + s.Pages.Notice(w, noticeId, "Failed to add member, identity resolution failed.") 529 + return 530 + } 531 532 // write to pds 533 client, err := s.OAuth.AuthorizedClient(r) ··· 650 651 652 653 s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") 654 return 655 }

History

2 rounds 2 comments

yemou.pink submitted #1 2mo

diff

1 commit

expand

ffe32bbc

appview/knots,spindles: ignore invalid handles when removing members

expand 1 comment

oppi.li 2mo

lgtm! thanks for the contribution.

pull request successfully merged

yemou.pink submitted #0 2mo

diff

1 commit

expand

f0df8870

appview/knots,spindles: ignore invalid handles when removing members

expand 1 comment

yemou.pink 2mo

I made a mistake here