tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages: resolve did on render #801

merged opened by boltless.me targeting master from sl/yurolxtlpsmz

Don't pass resolved user handles from http handlers. The page renderer is capable of resolving DIDs and we are using redis cache, so the performance won't matter much either.

Signed-off-by: Seongmin Lee git@boltless.me

STACK 11
#821 appview: remove ResolvedRepo for eternity
3
#2
#820 appview: remove use of all fields under ResolvedRepo
0
#2
#812 appview: prefer models.Repo over ResolvedRepo internally
0
#3
#811 appview/pages: fix pages.RepoComparedDiffFragment()
0
#4
#810 appview: use less RepoInfo for ResolvedRepo
0
#4
#809 appview: remove ResolvedRepo.RolesInRepo()
0
#4
#808 appview: diet the reporesolver
0
#4
#807 appview: remove unused fields on RepoInfo
0
#4
#802 appview: use less OwnerSlashRepo() in handlers
1
#5
#801 appview/pages: resolve did on render
0
#5
#806 appview/db: remove unused struct
0
#4
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m5mgmc446o22
+6 -6
Interdiff #3 → #4
unified split
appview/pages/funcmap.go

This patch was likely rebased, as context lines do not match.

+6 -6
appview/pages/pages.go
··· 482 482 483 483 type ProfileCard struct { 484 484 UserDid string 485 + UserHandle string 485 486 FollowStatus models.FollowStatus 486 487 Punchcard *models.Punchcard 487 488 Profile *models.Profile ··· 491 492 492 493 type ProfileCard struct { 493 494 UserDid string 494 - UserHandle string 495 495 FollowStatus models.FollowStatus 496 496 Punchcard *models.Punchcard 497 497 Profile *models.Profile ··· 830 830 } 831 831 832 832 type Collaborator struct { 833 - Did string 834 - Role string 833 + Did string 834 + Handle string 835 + Role string 835 836 } 836 837 837 838 type RepoSettingsParams struct { ··· 839 840 } 840 841 841 842 type Collaborator struct { 842 - Did string 843 - Handle string 844 - Role string 843 + Did string 844 + Role string 845 845 } 846 846 847 847 type RepoSettingsParams struct {
appview/pages/repoinfo/repoinfo.go

This file has not been changed.

appview/pages/templates/layouts/profilebase.html

This file has not been changed.

appview/pages/templates/repo/empty.html

This file has not been changed.

appview/pages/templates/repo/fragments/cloneDropdown.html

This file has not been changed.

appview/pages/templates/repo/settings/access.html

This file has not been changed.

appview/pages/templates/strings/dashboard.html

This file has not been changed.

appview/pages/templates/strings/string.html

This file has not been changed.

appview/pages/templates/user/followers.html

This file has not been changed.

appview/pages/templates/user/following.html

This file has not been changed.

appview/pages/templates/user/fragments/profileCard.html

This file has not been changed.

appview/pages/templates/user/overview.html

This file has not been changed.

appview/pages/templates/user/repos.html

This file has not been changed.

appview/pages/templates/user/starred.html

This file has not been changed.

appview/pages/templates/user/strings.html

This file has not been changed.

appview/reporesolver/resolver.go

This file has not been changed.

appview/state/profile.go

This patch was likely rebased, as context lines do not match.

History

6 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #5
diff interdiff
1 commit
expand
788ab682
appview/pages: resolve did on render
expand 0 comments
pull request successfully merged
boltless.me submitted #4
diff
1 commit
expand
788ab682
appview/pages: resolve did on render
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
ece1adf5
appview/pages: resolve did on render
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
ece1adf5
appview/pages: resolve did on render
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
ece1adf5
appview/pages: resolve did on render
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
ee72e288
appview/pages: resolve did on render
expand 0 comments