Monorepo for Tangled tangled.org

appview/pages: resolve did on render #801

merged opened by

boltless.me 3 months ago targeting master from sl/yurolxtlpsmz

Don't pass resolved user handles from http handlers. The page renderer is capable of resolving DIDs and we are using redis cache, so the performance won't matter much either.

Signed-off-by: Seongmin Lee git@boltless.me

STACK 11

#821 appview: remove ResolvedRepo for eternity

3 comments

round #2

#820 appview: remove use of all fields under ResolvedRepo

0 comments

round #2

#812 appview: prefer models.Repo over ResolvedRepo internally

0 comments

round #3

#811 appview/pages: fix pages.RepoComparedDiffFragment()

0 comments

round #4

#810 appview: use less RepoInfo for ResolvedRepo

0 comments

round #4

#809 appview: remove ResolvedRepo.RolesInRepo()

0 comments

round #4

#808 appview: diet the reporesolver

0 comments

round #4

#807 appview: remove unused fields on RepoInfo

0 comments

round #4

#802 appview: use less OwnerSlashRepo() in handlers

1 comment

round #5

#801 appview/pages: resolve did on render

0 comments

round #5

#806 appview/db: remove unused struct

0 comments

round #4

Labels

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m5mgmc446o22

+3 -3

18 changed files

Interdiff #0 → #1

expand all

unified split

appview

pages

funcmap.go

pages.go

repoinfo

repoinfo.go

templates

layouts

profilebase.html

repo

empty.html

fragments

cloneDropdown.html

settings

access.html

strings

dashboard.html

string.html

user

followers.html

following.html

fragments

profileCard.html

overview.html

repos.html

starred.html

strings.html

reporesolver

resolver.go

state

profile.go

+1 -1

appview/pages/funcmap.go

··· 78 78 } 79 79 handle := ownerId.Handle 80 80 if handle != "" && !handle.IsInvalidHandle() { 81 - return string(handle)+"/"+repo.Name 81 + return string(handle) + "/" + repo.Name 82 82 } 83 83 return repo.DidSlashRepo() 84 84 },

+2 -2

appview/pages/pages.go

··· 830 830 } 831 831 832 832 type Collaborator struct { 833 - Did string 834 - Role string 833 + Did string 834 + Role string 835 835 } 836 836 837 837 type RepoSettingsParams struct {

appview/pages/repoinfo/repoinfo.go