tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: notify users mentioned in issues #738

merged opened by boltless.me targeting master from feat/mentions
STACK 4
#765 draft: render backlinks
3/3
1
#11
#764 appview/pages: fix broken issue-comment links
0/3
0
#11
#761 appview,lexicons: atprotate the mentions & references
0/3
0
#12
#760 appview: parse reference links from markdown body
0/3
0
#12
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4jbido5pi22
Interdiff #1 → #2
unified split
appview/indexer/notifier.go

This file has not been changed.

appview/issues/issues.go

This file has not been changed.

appview/notify/db/db.go

This file has not been changed.

appview/notify/merged_notifier.go

This patch was likely rebased, as context lines do not match.

appview/notify/notifier.go

This patch was likely rebased, as context lines do not match.

appview/notify/posthog/notifier.go

This file has not been changed.

History

14 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #13
diff interdiff
1 commit
expand
bc693fa8
appview/notify: notify users mentioned in issues
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #12
diff interdiff
1 commit
expand
87e40fd1
appview/notify: notify users mentioned in issues
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #11
diff interdiff
1 commit
expand
87e40fd1
appview/notify: notify users mentioned in issues
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #10
diff interdiff
1 commit
expand
37b7f8eb
appview/notify: notify users mentioned in issues
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #9
diff interdiff
1 commit
expand
137cc1d5
appview/notify: notify users mentioned in issues
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
024f313d
appview/notify: notify users mentioned in issues
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
66964960
appview/notify: notify users mentioned in issues
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
66964960
appview/notify: notify users mentioned in issues
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
2c5719ae
appview/notify: notify users mentioned in issues
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
f34a53e7
appview/notify: notify users mentioned in issues
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
f01363d5
appview/notify: notify users mentioned in issues
1/3 failed, 1/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #2
diff
1 commit
expand
2eedcf5d
appview/notify: notify users mentioned in issues
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
93cc31e3
appview/notify: notify users mentioned in issues
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 2 comments
oppi.li

the way i'd want to see this implemented is like so:

  • the handle mentions are rewritten by the appview to point to a DID (this way mentions continue to work across handle changes). this can happen when creating a new issue or a new comment. note that when editing a text field, this needs to be retranslated from DID back to handle. we do something similar in labels that accept DIDs for example
  • next, we can introduce models.IssueComment.Mentions to get a list of DIDs mentioned in the text of a comment, and notify them accordingly, upon creation.
boltless.me

I've considered it, but decided to go without did transitions for now. We can merge this as a temporary solution and introduce did-hardening later.

Also not sure, how would that look like in markdown. you mean like this: @did:plc:someone?

boltless.me submitted #0
diff
1 commit
expand
93cc31e3
appview/notify: notify users mentioned in issues
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments