tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: notify users mentioned in issues #738

merged opened by boltless.me targeting master from feat/mentions
STACK 4
#765 draft: render backlinks
1
#11
#764 appview/pages: fix broken issue-comment links
0
#11
#761 appview,lexicons: atprotate the mentions & references
0
#12
#760 appview: parse reference links from markdown body
0
#12
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4jbido5pi22
+24
Interdiff #12 → #13
unified split
appview/indexer/notifier.go

This file has not been changed.

appview/issues/issues.go

This file has not been changed.

appview/notify/db/db.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/notify/notifier.go

This file has not been changed.

appview/notify/posthog/notifier.go

This file has not been changed.

+24
appview/pages/markup/markdown.go
··· 302 302 return path.Join(rctx.CurrentDir, dst) 303 303 } 304 304 305 + // FindUserMentions returns Set of user handles from given markup soruce. 306 + // It doesn't guarntee unique DIDs 307 + func FindUserMentions(source string) []string { 308 + var ( 309 + mentions []string 310 + mentionsSet = make(map[string]struct{}) 311 + md = NewMarkdown() 312 + sourceBytes = []byte(source) 313 + root = md.Parser().Parse(text.NewReader(sourceBytes)) 314 + ) 315 + ast.Walk(root, func(n ast.Node, entering bool) (ast.WalkStatus, error) { 316 + if entering && n.Kind() == textension.KindAt { 317 + handle := n.(*textension.AtNode).Handle 318 + mentionsSet[handle] = struct{}{} 319 + return ast.WalkSkipChildren, nil 320 + } 321 + return ast.WalkContinue, nil 322 + }) 323 + for handle := range mentionsSet { 324 + mentions = append(mentions, handle) 325 + } 326 + return mentions 327 + } 328 + 305 329 func isAbsoluteUrl(link string) bool { 306 330 parsed, err := url.Parse(link) 307 331 if err != nil {

History

14 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #13
diff
1 commit
expand
bc693fa8
appview/notify: notify users mentioned in issues
expand 0 comments
pull request successfully merged
boltless.me submitted #12
diff interdiff
1 commit
expand
87e40fd1
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #11
diff interdiff
1 commit
expand
87e40fd1
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #10
diff interdiff
1 commit
expand
37b7f8eb
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #9
diff interdiff
1 commit
expand
137cc1d5
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
024f313d
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
66964960
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
66964960
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
2c5719ae
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
f34a53e7
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
f01363d5
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
2eedcf5d
appview/notify: notify users mentioned in issues
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
93cc31e3
appview/notify: notify users mentioned in issues
expand 2 comments
oppi.li

the way i'd want to see this implemented is like so:

  • the handle mentions are rewritten by the appview to point to a DID (this way mentions continue to work across handle changes). this can happen when creating a new issue or a new comment. note that when editing a text field, this needs to be retranslated from DID back to handle. we do something similar in labels that accept DIDs for example
  • next, we can introduce models.IssueComment.Mentions to get a list of DIDs mentioned in the text of a comment, and notify them accordingly, upon creation.
boltless.me

I've considered it, but decided to go without did transitions for now. We can merge this as a temporary solution and introduce did-hardening later.

Also not sure, how would that look like in markdown. you mean like this: @did:plc:someone?

boltless.me submitted #0
diff
1 commit
expand
93cc31e3
appview/notify: notify users mentioned in issues
expand 0 comments