Signed-off-by: Seongmin Lee boltlessengineer@proton.me
appview/pages/markup/markdown.go
This file has not been changed.
appview/pages/markup/markdown_at_extension.go
This file has not been changed.
History
14 rounds
6 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 failed
expand
collapse
expand 1 comment
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
1/3 failed, 2/3 timeout
expand
collapse
expand 2 comments
@anirudh.fi I moved it to markup/extension/atlink.go. does this seem good?
I originally named it that way because I thought we will introduce non-markdown renderers in future. So, considering we already have markup/markdown.go, markup/markdown_sthsth.go seems reasonable.
Maybe it was bit too early.
Ah, I see. I appreciate the rationale, but we won’t support non-markdown renderers for comments/issues/other text bodies that aren’t the readme itself. Once we do support other renderers. we can subpackage this under ‘markdown’.
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 1 comment
We will likely add more extensions to the markdown renderer in the future (one immediate example is callouts, which I plan to fork and modify in-tree). Maybe we can have an extensions subpackage under the markdown package?
And maybe rename the markdown_at_extension.go to just atlink.go?
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
1/3 failed, 1/3 timeout, 1/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
add custom styling rule for mention links (no underline unless hover)
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
1/3 failed, 1/3 timeout, 1/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 2 comments
ah forgot to remove that test code. resubmitting with style update! (following github style and match with current user handle styles)
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
1/3 failed, 1/3 timeout, 1/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
1/3 failed, 2/3 timeout
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
@ user-mention parsing in markdown
Signed-off-by: Seongmin Lee <boltlessengineer@proton.me>
resubmitting with format fix