Monorepo for Tangled tangled.org

appview/pages: markup: add @ user-mention parsing in markdown #736

merged opened by boltless.me targeting master from feat/mentions
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4jbido5pa22
Interdiff #10 #11
appview/pages/markup/extension/atlink.go

This file has not been changed.

appview/pages/markup/markdown.go

This file has not been changed.

appview/pages/markup/sanitizer.go

This file has not been changed.

input.css

This file has not been changed.

History

14 rounds 6 comments
sign up or login to add to the discussion
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 failed
expand
expand 1 comment

resubmitting with format fix

1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
1/3 failed, 2/3 timeout
expand
expand 2 comments

@anirudh.fi I moved it to markup/extension/atlink.go. does this seem good? I originally named it that way because I thought we will introduce non-markdown renderers in future. So, considering we already have markup/markdown.go, markup/markdown_sthsth.go seems reasonable. Maybe it was bit too early.

Ah, I see. I appreciate the rationale, but we won’t support non-markdown renderers for comments/issues/other text bodies that aren’t the readme itself. Once we do support other renderers. we can subpackage this under ‘markdown’.

1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 1 comment

We will likely add more extensions to the markdown renderer in the future (one immediate example is callouts, which I plan to fork and modify in-tree). Maybe we can have an extensions subpackage under the markdown package?

And maybe rename the markdown_at_extension.go to just atlink.go?

1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
1/3 failed, 1/3 timeout, 1/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
1/3 failed, 1/3 timeout, 1/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 2 comments

this class seems to not be used (it does not render as text-red-500 for me atleast?), is this intentional?

in any case, i think the current styles for the mention (styled as a a tag) look good. github's style for mentions would be cool too (bold without underline, but still linked).

ah forgot to remove that test code. resubmitting with style update! (following github style and match with current user handle styles)

1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
1/3 failed, 1/3 timeout, 1/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
1/3 failed, 2/3 timeout
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: markup: add @ user-mention parsing in markdown
3/3 success
expand
expand 0 comments