Monorepo for Tangled tangled.org

appview/oauth: handle failed login with error code #717

merged opened by boltless.me targeting master from push-zmowtwoprttl
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3v6tckw6s22
+5 -4
Interdiff #1 โ†’ #2
appview/oauth/handler.go

This file has not been changed.

appview/pages/pages.go

This file has not been changed.

+5 -4
appview/pages/templates/user/login.html
··· 63 63 <h5 class="font-medium">Login error</h5> 64 64 <p class="text-sm"> 65 65 {{ if eq .ErrorCode "access_denied" }} 66 - You have not authorized the app. Please try again 66 + You have not authorized the app. 67 67 {{ else if eq .ErrorCode "session" }} 68 - Server failed to create user session. Please try again 68 + Server failed to create user session. 69 69 {{ else }} 70 - Internal Server error. Please try again 71 - </p> 70 + Internal Server error. 72 71 {{ end }} 72 + Please try again. 73 + </p> 73 74 </div> 74 75 </div> 75 76 {{ end }}
appview/state/login.go

This file has not been changed.

History

3 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
appview/oauth: handle failed login with error code
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview/oauth: handle failed login with error code
3/3 success
expand
expand 1 comment

Oh, just noticed; super tiny nit about the copy text: can you end each sentence a period? So, "โ€ฆ Please try again." (ending with a ".")

1 commit
expand
appview/oauth: handle failed login with error code
1/3 failed, 2/3 timeout
expand
expand 1 comment

Looks good! A quick nix run .#fmt and we should be good to merge.