tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/oauth: handle failed login with error code #717

merged opened by boltless.me targeting master from push-zmowtwoprttl
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3v6tckw6s22
+2 -2
Interdiff #0 → #1
unified split
appview/oauth/handler.go

This file has not been changed.

+2 -2
appview/pages/pages.go
··· 220 220 } 221 221 222 222 type LoginParams struct { 223 - ReturnUrl string 224 - ErrorCode string 223 + ReturnUrl string 224 + ErrorCode string 225 225 } 226 226 227 227 func (p *Pages) Login(w io.Writer, params LoginParams) error {
appview/pages/templates/user/login.html

This file has not been changed.

appview/state/login.go

This file has not been changed.

History

3 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #2
diff interdiff
1 commit
expand
2d890dbb
appview/oauth: handle failed login with error code
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #1
diff
1 commit
expand
2c0eb95a
appview/oauth: handle failed login with error code
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
anirudh.fi

Oh, just noticed; super tiny nit about the copy text: can you end each sentence a period? So, "… Please try again." (ending with a ".")

boltless.me submitted #0
diff
1 commit
expand
009dc250
appview/oauth: handle failed login with error code
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 1 comment
anirudh.fi

Looks good! A quick nix run .#fmt and we should be good to merge.