freshlybakedca.ke / git
Git fork
fork atom

Makefile: set default goals in makefiles

Explicitly set the default goal at the very top of various makefiles.
This is already present in some makefiles, but not all of them.

In particular, this corrects a regression introduced in a38edab7c8
(Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06). That
commit added some config files as build targets for the Documentation
directory, and put the target configuration in a sensible place.
Unfortunately, that sensible place was above any other build target
definitions, meaning the default goal changed to being those
configuration files only, rather than the HTML and man page
documentation.

Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

authored by

Adam Dinwoodie and committed by
Junio C Hamano 5309c1e9 063bcebf

+46 -11
unified split
+4 -1
Documentation/Makefile
··· 1 # Import tree-wide shared Makefile behavior and libraries 2 include ../shared.mak 3 ··· 236 ASCIIDOC_EXTRA += -a 'git-default-editor=$(DEFAULT_EDITOR_SQ)' 237 endif 238 239 - all: html man 240 241 html: $(DOC_HTML) 242
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 # Import tree-wide shared Makefile behavior and libraries 5 include ../shared.mak 6 ··· 239 ASCIIDOC_EXTRA += -a 'git-default-editor=$(DEFAULT_EDITOR_SQ)' 240 endif 241 242 + all:: html man 243 244 html: $(DOC_HTML) 245
+3
contrib/credential/libsecret/Makefile
··· 1 MAIN:=git-credential-libsecret 2 all:: $(MAIN) 3
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 MAIN:=git-credential-libsecret 5 all:: $(MAIN) 6
+1
contrib/credential/osxkeychain/Makefile
··· 1 all:: git-credential-osxkeychain 2 3 CC = gcc
··· 1 + # The default target of this Makefile is... 2 all:: git-credential-osxkeychain 3 4 CC = gcc
+2 -1
contrib/credential/wincred/Makefile
··· 1 - all: git-credential-wincred.exe 2 3 -include ../../../config.mak.autogen 4 -include ../../../config.mak
··· 1 + # The default target of this Makefile is... 2 + all:: git-credential-wincred.exe 3 4 -include ../../../config.mak.autogen 5 -include ../../../config.mak
+2 -1
contrib/diff-highlight/Makefile
··· 1 - all: diff-highlight 2 3 PERL_PATH = /usr/bin/perl 4 -include ../../config.mak
··· 1 + # The default target of this Makefile is... 2 + all:: diff-highlight 3 4 PERL_PATH = /usr/bin/perl 5 -include ../../config.mak
+4 -1
contrib/diff-highlight/t/Makefile
··· 1 -include ../../../config.mak.autogen 2 -include ../../../config.mak 3 ··· 6 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 7 T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh) 8 9 - all: test 10 test: $(T) 11 12 .PHONY: help clean all test $(T)
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 -include ../../../config.mak.autogen 5 -include ../../../config.mak 6 ··· 9 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 10 T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh) 11 12 + all:: test 13 test: $(T) 14 15 .PHONY: help clean all test $(T)
+4 -1
contrib/mw-to-git/Makefile
··· 12 # 13 # make install 14 15 GIT_MEDIAWIKI_PM=Git/Mediawiki.pm 16 SCRIPT_PERL=git-remote-mediawiki.perl 17 SCRIPT_PERL+=git-mw.perl ··· 27 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 28 INSTLIBDIR_SQ = $(subst ','\'',$(INSTLIBDIR)) 29 30 - all: build 31 32 test: all 33 $(MAKE) -C t
··· 12 # 13 # make install 14 15 + # The default target of this Makefile is... 16 + all:: 17 + 18 GIT_MEDIAWIKI_PM=Git/Mediawiki.pm 19 SCRIPT_PERL=git-remote-mediawiki.perl 20 SCRIPT_PERL+=git-mw.perl ··· 30 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 31 INSTLIBDIR_SQ = $(subst ','\'',$(INSTLIBDIR)) 32 33 + all:: build 34 35 test: all 36 $(MAKE) -C t
+2 -1
contrib/mw-to-git/t/Makefile
··· 8 # 9 ## Test git-remote-mediawiki 10 11 - all: test 12 13 -include ../../../config.mak.autogen 14 -include ../../../config.mak
··· 8 # 9 ## Test git-remote-mediawiki 10 11 + # The default target of this Makefile is... 12 + all:: test 13 14 -include ../../../config.mak.autogen 15 -include ../../../config.mak
+4 -1
contrib/persistent-https/Makefile
··· 12 # See the License for the specific language governing permissions and 13 # limitations under the License. 14 15 BUILD_LABEL=$(shell cut -d" " -f3 ../../GIT-VERSION-FILE) 16 TAR_OUT=$(shell go env GOOS)_$(shell go env GOARCH).tar.gz 17 18 - all: git-remote-persistent-https git-remote-persistent-https--proxy \ 19 git-remote-persistent-http 20 21 git-remote-persistent-https--proxy: git-remote-persistent-https
··· 12 # See the License for the specific language governing permissions and 13 # limitations under the License. 14 15 + # The default target of this Makefile is... 16 + all:: 17 + 18 BUILD_LABEL=$(shell cut -d" " -f3 ../../GIT-VERSION-FILE) 19 TAR_OUT=$(shell go env GOOS)_$(shell go env GOARCH).tar.gz 20 21 + all:: git-remote-persistent-https git-remote-persistent-https--proxy \ 22 git-remote-persistent-http 23 24 git-remote-persistent-https--proxy: git-remote-persistent-https
+4 -1
contrib/subtree/t/Makefile
··· 3 # Copyright (c) 2005 Junio C Hamano 4 # 5 6 -include ../../../config.mak.autogen 7 -include ../../../config.mak 8 ··· 31 TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh)) 32 THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh))) 33 34 - all: $(DEFAULT_TEST_TARGET) 35 36 test: pre-clean $(TEST_LINT) 37 $(MAKE) aggregate-results-and-cleanup
··· 3 # Copyright (c) 2005 Junio C Hamano 4 # 5 6 + # The default target of this Makefile is... 7 + all:: 8 + 9 -include ../../../config.mak.autogen 10 -include ../../../config.mak 11 ··· 34 TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh)) 35 THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh))) 36 37 + all:: $(DEFAULT_TEST_TARGET) 38 39 test: pre-clean $(TEST_LINT) 40 $(MAKE) aggregate-results-and-cleanup
+1
git-gui/Makefile
··· 1 all:: 2 3 # Define V=1 to have a more verbose compile.
··· 1 + # The default target of this Makefile is... 2 all:: 3 4 # Define V=1 to have a more verbose compile.
+3
git-gui/po/glossary/Makefile
··· 1 PO_TEMPLATE = git-gui-glossary.pot 2 3 ALL_POFILES = $(wildcard *.po)
··· 1 + # The default target of this Makefile is... 2 + update-po:: 3 + 4 PO_TEMPLATE = git-gui-glossary.pot 5 6 ALL_POFILES = $(wildcard *.po)
+4 -1
t/interop/Makefile
··· 1 # Import tree-wide shared Makefile behavior and libraries 2 include ../../shared.mak 3 ··· 8 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 9 T = $(sort $(wildcard i[0-9][0-9][0-9][0-9]-*.sh)) 10 11 - all: $(T) 12 13 $(T): 14 @echo "*** $@ ***"; '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 # Import tree-wide shared Makefile behavior and libraries 5 include ../../shared.mak 6 ··· 11 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 12 T = $(sort $(wildcard i[0-9][0-9][0-9][0-9]-*.sh)) 13 14 + all:: $(T) 15 16 $(T): 17 @echo "*** $@ ***"; '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)
+4 -1
t/perf/Makefile
··· 1 # Import tree-wide shared Makefile behavior and libraries 2 include ../../shared.mak 3 4 -include ../../config.mak 5 export GIT_TEST_OPTIONS 6 7 - all: test-lint perf 8 9 perf: pre-clean 10 ./run
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 # Import tree-wide shared Makefile behavior and libraries 5 include ../../shared.mak 6 7 -include ../../config.mak 8 export GIT_TEST_OPTIONS 9 10 + all:: test-lint perf 11 12 perf: pre-clean 13 ./run
+4 -1
templates/Makefile
··· 1 # Import tree-wide shared Makefile behavior and libraries 2 include ../shared.mak 3 ··· 23 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 24 template_instdir_SQ = $(subst ','\'',$(template_instdir)) 25 26 - all: boilerplates.made custom 27 28 # Put templates that can be copied straight from the source 29 # in a file direc--tory--file in the source. They will be
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 4 # Import tree-wide shared Makefile behavior and libraries 5 include ../shared.mak 6 ··· 26 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 27 template_instdir_SQ = $(subst ','\'',$(template_instdir)) 28 29 + all:: boilerplates.made custom 30 31 # Put templates that can be copied straight from the source 32 # in a file direc--tory--file in the source. They will be