freshlybakedca.ke / git
Git fork
fork atom

Makefile: set default goals in makefiles

Explicitly set the default goal at the very top of various makefiles.
This is already present in some makefiles, but not all of them.

In particular, this corrects a regression introduced in a38edab7c8
(Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06). That
commit added some config files as build targets for the Documentation
directory, and put the target configuration in a sensible place.
Unfortunately, that sensible place was above any other build target
definitions, meaning the default goal changed to being those
configuration files only, rather than the HTML and man page
documentation.

Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

authored by

Adam Dinwoodie and committed by
Junio C Hamano 5309c1e9 063bcebf

+46 -11
unified split
+4 -1
Documentation/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 # Import tree-wide shared Makefile behavior and libraries 2 5 include ../shared.mak 3 6 ··· 236 239 ASCIIDOC_EXTRA += -a 'git-default-editor=$(DEFAULT_EDITOR_SQ)' 237 240 endif 238 241 239 - all: html man 242 + all:: html man 240 243 241 244 html: $(DOC_HTML) 242 245
+3
contrib/credential/libsecret/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 MAIN:=git-credential-libsecret 2 5 all:: $(MAIN) 3 6
+1
contrib/credential/osxkeychain/Makefile
··· 1 + # The default target of this Makefile is... 1 2 all:: git-credential-osxkeychain 2 3 3 4 CC = gcc
+2 -1
contrib/credential/wincred/Makefile
··· 1 - all: git-credential-wincred.exe 1 + # The default target of this Makefile is... 2 + all:: git-credential-wincred.exe 2 3 3 4 -include ../../../config.mak.autogen 4 5 -include ../../../config.mak
+2 -1
contrib/diff-highlight/Makefile
··· 1 - all: diff-highlight 1 + # The default target of this Makefile is... 2 + all:: diff-highlight 2 3 3 4 PERL_PATH = /usr/bin/perl 4 5 -include ../../config.mak
+4 -1
contrib/diff-highlight/t/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 -include ../../../config.mak.autogen 2 5 -include ../../../config.mak 3 6 ··· 6 9 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 7 10 T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh) 8 11 9 - all: test 12 + all:: test 10 13 test: $(T) 11 14 12 15 .PHONY: help clean all test $(T)
+4 -1
contrib/mw-to-git/Makefile
··· 12 12 # 13 13 # make install 14 14 15 + # The default target of this Makefile is... 16 + all:: 17 + 15 18 GIT_MEDIAWIKI_PM=Git/Mediawiki.pm 16 19 SCRIPT_PERL=git-remote-mediawiki.perl 17 20 SCRIPT_PERL+=git-mw.perl ··· 27 30 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 28 31 INSTLIBDIR_SQ = $(subst ','\'',$(INSTLIBDIR)) 29 32 30 - all: build 33 + all:: build 31 34 32 35 test: all 33 36 $(MAKE) -C t
+2 -1
contrib/mw-to-git/t/Makefile
··· 8 8 # 9 9 ## Test git-remote-mediawiki 10 10 11 - all: test 11 + # The default target of this Makefile is... 12 + all:: test 12 13 13 14 -include ../../../config.mak.autogen 14 15 -include ../../../config.mak
+4 -1
contrib/persistent-https/Makefile
··· 12 12 # See the License for the specific language governing permissions and 13 13 # limitations under the License. 14 14 15 + # The default target of this Makefile is... 16 + all:: 17 + 15 18 BUILD_LABEL=$(shell cut -d" " -f3 ../../GIT-VERSION-FILE) 16 19 TAR_OUT=$(shell go env GOOS)_$(shell go env GOARCH).tar.gz 17 20 18 - all: git-remote-persistent-https git-remote-persistent-https--proxy \ 21 + all:: git-remote-persistent-https git-remote-persistent-https--proxy \ 19 22 git-remote-persistent-http 20 23 21 24 git-remote-persistent-https--proxy: git-remote-persistent-https
+4 -1
contrib/subtree/t/Makefile
··· 3 3 # Copyright (c) 2005 Junio C Hamano 4 4 # 5 5 6 + # The default target of this Makefile is... 7 + all:: 8 + 6 9 -include ../../../config.mak.autogen 7 10 -include ../../../config.mak 8 11 ··· 31 34 TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh)) 32 35 THELPERS = $(sort $(filter-out $(T),$(wildcard *.sh))) 33 36 34 - all: $(DEFAULT_TEST_TARGET) 37 + all:: $(DEFAULT_TEST_TARGET) 35 38 36 39 test: pre-clean $(TEST_LINT) 37 40 $(MAKE) aggregate-results-and-cleanup
+1
git-gui/Makefile
··· 1 + # The default target of this Makefile is... 1 2 all:: 2 3 3 4 # Define V=1 to have a more verbose compile.
+3
git-gui/po/glossary/Makefile
··· 1 + # The default target of this Makefile is... 2 + update-po:: 3 + 1 4 PO_TEMPLATE = git-gui-glossary.pot 2 5 3 6 ALL_POFILES = $(wildcard *.po)
+4 -1
t/interop/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 # Import tree-wide shared Makefile behavior and libraries 2 5 include ../../shared.mak 3 6 ··· 8 11 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) 9 12 T = $(sort $(wildcard i[0-9][0-9][0-9][0-9]-*.sh)) 10 13 11 - all: $(T) 14 + all:: $(T) 12 15 13 16 $(T): 14 17 @echo "*** $@ ***"; '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)
+4 -1
t/perf/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 # Import tree-wide shared Makefile behavior and libraries 2 5 include ../../shared.mak 3 6 4 7 -include ../../config.mak 5 8 export GIT_TEST_OPTIONS 6 9 7 - all: test-lint perf 10 + all:: test-lint perf 8 11 9 12 perf: pre-clean 10 13 ./run
+4 -1
templates/Makefile
··· 1 + # The default target of this Makefile is... 2 + all:: 3 + 1 4 # Import tree-wide shared Makefile behavior and libraries 2 5 include ../shared.mak 3 6 ··· 23 26 DESTDIR_SQ = $(subst ','\'',$(DESTDIR)) 24 27 template_instdir_SQ = $(subst ','\'',$(template_instdir)) 25 28 26 - all: boilerplates.made custom 29 + all:: boilerplates.made custom 27 30 28 31 # Put templates that can be copied straight from the source 29 32 # in a file direc--tory--file in the source. They will be