A modern Music Player Daemon based on Rockbox open source high quality audio player
libadwaita audio rust zig deno mpris rockbox mpd

themeeditor: Fix dmg deploy steps.

- Fix binary name in Info.plist.
- Run dmgbuild as Python module, in some cases it isn't available directly.
- Add missing dmgbuild configuration for themeeditor.

Change-Id: I2db50959b88283f43e2203cf71b130cdb33103dd

+22 -4
+4 -3
utils/cmake/deploy.cmake
··· 73 if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug") 74 message(WARNING "Deploying a Debug build.") 75 endif() 76 - set(DMGBUILD ${CMAKE_BINARY_DIR}/venv/bin/dmgbuild) 77 find_program(MACDEPLOYQT_EXECUTABLE macdeployqt HINTS "${qtbindir}") 78 79 add_custom_command( 80 COMMENT "Setting up dmgbuild virtualenv" 81 - OUTPUT ${DMGBUILD} 82 COMMAND python3 -m venv ${CMAKE_BINARY_DIR}/venv 83 COMMAND ${CMAKE_BINARY_DIR}/venv/bin/python -m pip install -q dmgbuild 84 ) ··· 92 -Dappbundle=${target}.app 93 ${target} ${CMAKE_BINARY_DIR}/${target}.dmg 94 DEPENDS ${target} 95 - ${DMGBUILD} 96 ) 97 add_custom_target(deploy_${target} 98 DEPENDS ${CMAKE_BINARY_DIR}/${target}.dmg)
··· 73 if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug") 74 message(WARNING "Deploying a Debug build.") 75 endif() 76 + set(DMGBUILD ${CMAKE_BINARY_DIR}/venv/bin/python3 -m dmgbuild) 77 + set(DMGBUILD_STAMP ${CMAKE_BINARY_DIR}/dmgbuild.stamp) 78 find_program(MACDEPLOYQT_EXECUTABLE macdeployqt HINTS "${qtbindir}") 79 80 add_custom_command( 81 COMMENT "Setting up dmgbuild virtualenv" 82 + OUTPUT ${DMGBUILD_STAMP} 83 COMMAND python3 -m venv ${CMAKE_BINARY_DIR}/venv 84 COMMAND ${CMAKE_BINARY_DIR}/venv/bin/python -m pip install -q dmgbuild 85 ) ··· 93 -Dappbundle=${target}.app 94 ${target} ${CMAKE_BINARY_DIR}/${target}.dmg 95 DEPENDS ${target} 96 + ${DMGBUILD_STAMP} 97 ) 98 add_custom_target(deploy_${target} 99 DEPENDS ${CMAKE_BINARY_DIR}/${target}.dmg)
+1 -1
utils/themeeditor/Info.plist
··· 3 <plist version="0.9"> 4 <dict> 5 <key>CFBundleExecutable</key> 6 - <string>rbthemeeditor</string> 7 <key>CFBundleName</key> 8 <string>Theme Editor</string> 9 <key>CFBundleShortVersionString</key>
··· 3 <plist version="0.9"> 4 <dict> 5 <key>CFBundleExecutable</key> 6 + <string>RockboxThemeEditor</string> 7 <key>CFBundleName</key> 8 <string>Theme Editor</string> 9 <key>CFBundleShortVersionString</key>
+17
utils/themeeditor/dmgbuild.cfg
···
··· 1 + # Configuration for creating a dmg with dmgbuild 2 + # (https://github.com/al45tair/dmgbuild) 3 + # Requires at least Python 3.4 4 + 5 + import os 6 + import plistlib 7 + 8 + _appbundle = defines['appbundle'] 9 + _plfile = open(os.path.join(_appbundle, 'Contents/Info.plist')) 10 + _pldata = _plfile.read().encode() 11 + _plist = plistlib.loads(_pldata) 12 + _iconfile = os.path.join(_appbundle, 'Contents/Resources', _plist['CFBundleIconFile']) 13 + 14 + files = [ _appbundle ] 15 + icon = _iconfile 16 + background = '#c6d6f5' 17 +