tsiry-sandratraina.com / rockbox-zig
A modern Music Player Daemon based on Rockbox open source high quality audio player
libadwaita audio rust zig deno mpris rockbox mpd
fork atom

FS#13350: PictureFlow: Fix too few albums displayed for first artist

Using pf_idx.album_untagged_idx initialized as to -1 instead of 0,
we can get rid of buggy duplicate untagged albums while keeping "usable"
untagged albums and properly displaying all albums for the first artist
when there are no untagged ablums at all.

Change-Id: I067ce0bba4ece5e2d9466ffd075af8bf653633b4

authored by

Johannes Roos and committed by
Solomon Peachy 994acefa b4a276e1

+3 -11
+3 -11
apps/plugins/pictureflow/pictureflow.c
··· 1398 1398 /* Albums */ 1399 1399 pf_idx.album_ct = 0; 1400 1400 pf_idx.album_len =0; 1401 - pf_idx.album_untagged_idx = 0; 1401 + pf_idx.album_untagged_idx = -1; 1402 1402 pf_idx.album_untagged_seek = -1; 1403 1403 1404 1404 /* album_index starts at end of buf it will be rearranged when finalized */ ··· 1523 1523 1524 1524 /* remove any extra untagged albums 1525 1525 * extra space is orphaned till restart */ 1526 - for (i = 0; i < pf_idx.album_ct; i++) 1527 - { 1528 - if (pf_idx.album_index[i].artist_idx > 0) 1529 - { 1530 - if (i > 0) { i--; } 1531 - pf_idx.album_index += i; 1532 - pf_idx.album_ct -= i; 1533 - break; 1534 - } 1535 - } 1526 + pf_idx.album_index += pf_idx.album_untagged_idx + 1; 1527 + pf_idx.album_ct -= pf_idx.album_untagged_idx + 1; 1536 1528 1537 1529 pf_idx.buf = buf; 1538 1530 pf_idx.buf_sz = buf_size;