tsiry-sandratraina.com / rockbox-zig
A modern Music Player Daemon based on Rockbox open source high quality audio player
libadwaita audio rust zig deno mpris rockbox mpd
fork atom

Fix path buffer overflow in screendump

Overflow is due to a hidden assumption in create_datetime_filename()
and create_numbered_filename() where buffer must be >= MAX_PATH bytes.

Change-Id: I9d36517d861b6925352380d551afc5439edbb340

Aidan MacDonald 34fcea0b 835d0c73

+2 -2
unified split
+2 -2
firmware/screendump.c
··· 102 102 void screen_dump(void) 103 103 { 104 104 int fd, y; 105 - char filename[32]; 105 + char filename[MAX_PATH]; 106 106 107 107 fb_data *src; 108 108 #if LCD_DEPTH == 1 ··· 306 306 void remote_screen_dump(void) 307 307 { 308 308 int fd, y; 309 - char filename[32]; 309 + char filename[MAX_PATH]; 310 310 311 311 fb_remote_data *src; 312 312 #if LCD_REMOTE_DEPTH == 1