appview: allows a default knot to be configured #991

+168 -13

13 changed files

Diff round #5

expand all

unified split

appview

db.go

preferences.go

profile.go

knots

knots.go

models

preferences.go

pages

pages.go

templates

knots

index.html

repo

fork.html

new.html

repo

repo.go

state

profile.go

router.go

state.go

+7 -1

appview/db/db.go

··· 567 567 unique (from_at, to_at) 568 568 ); 569 569 570 + create table if not exists knot_preferences ( 571 + id integer primary key autoincrement, 572 + user_did text not null unique, 573 + default_knot text 574 + ); 575 + 570 576 create table if not exists migrations ( 571 577 id integer primary key autoincrement, 572 578 name text unique ··· 1078 1084 // transfer data, constructing pull_at from pulls table 1079 1085 _, err = tx.Exec(` 1080 1086 insert into pull_submissions_new (id, pull_at, round_number, patch, created) 1081 - select 1087 + select 1082 1088 ps.id, 1083 1089 'at://' || p.owner_did || '/sh.tangled.repo.pull/' || p.rkey, 1084 1090 ps.round_number,

+42

appview/db/preferences.go

··· 1 + package db 2 + 3 + import ( 4 + "database/sql" 5 + 6 + "tangled.org/core/appview/models" 7 + ) 8 + 9 + func GetKnotPreference(e Execer, did string) (*models.KnotPreference, error) { 10 + var knotPreference models.KnotPreference 11 + 12 + err := e.QueryRow( 13 + `select id, user_did, default_knot from knot_preferences where user_did = ?`, 14 + did, 15 + ).Scan(&knotPreference.ID, &knotPreference.Did, &knotPreference.DefaultKnot) 16 + if err == sql.ErrNoRows { 17 + return nil, nil 18 + } 19 + 20 + if err != nil { 21 + return nil, err 22 + } 23 + 24 + return &knotPreference, nil 25 + } 26 + 27 + func UpsertKnotPreference(e Execer, did, defaultKnot string) error { 28 + _, err := e.Exec( 29 + `insert or replace into knot_preferences ( 30 + user_did, 31 + default_knot 32 + ) 33 + values (?, ?)`, 34 + did, 35 + defaultKnot, 36 + ) 37 + if err != nil { 38 + return err 39 + } 40 + 41 + return nil 42 + }

+2 -2

appview/db/profile.go

··· 138 138 description, 139 139 include_bluesky, 140 140 location, 141 - pronouns 141 + pronouns, 142 + default_knot 142 143 ) 143 144 values (?, ?, ?, ?, ?)`, 144 145 profile.Did, ··· 324 325 func GetProfile(e Execer, did string) (*models.Profile, error) { 325 326 var profile models.Profile 326 327 var pronouns sql.Null[string] 327 - 328 328 profile.Did = did 329 329 330 330 includeBluesky := 0

+22 -4

appview/knots/knots.go

··· 81 81 return 82 82 } 83 83 84 + availableKnots, err := k.Enforcer.GetKnotsForUser(user.Did()) 85 + if err != nil { 86 + k.Logger.Error("failed to fetch available knots for user", "err", err) 87 + w.WriteHeader(http.StatusInternalServerError) 88 + return 89 + } 90 + 91 + defaultKnot := "" 92 + knotPrefence, err := db.GetKnotPreference(k.Db, user.Did()) 93 + if err != nil { 94 + k.Logger.Warn("gettings users knot preferences", "error", err) 95 + } 96 + if knotPrefence != nil { 97 + defaultKnot = knotPrefence.DefaultKnot 98 + } 99 + 84 100 k.Pages.Knots(w, pages.KnotsParams{ 85 - LoggedInUser: user, 86 - Registrations: registrations, 87 - Tabs: knotsTabs, 88 - Tab: "knots", 101 + LoggedInUser: user, 102 + Registrations: registrations, 103 + Tabs: knotsTabs, 104 + Tab: "knots", 105 + AvailableKnots: availableKnots, 106 + DefaultKnot: defaultKnot, 89 107 }) 90 108 } 91 109

appview/models/preferences.go

··· 1 + package models 2 + 3 + type KnotPreference struct { 4 + ID int 5 + Did string 6 + DefaultKnot string 7 + }

+8 -4

appview/pages/pages.go

··· 417 417 } 418 418 419 419 type KnotsParams struct { 420 - LoggedInUser *oauth.MultiAccountUser 421 - Registrations []models.Registration 422 - Tabs []map[string]any 423 - Tab string 420 + LoggedInUser *oauth.MultiAccountUser 421 + Registrations []models.Registration 422 + Tabs []map[string]any 423 + Tab string 424 + AvailableKnots []string 425 + DefaultKnot string 424 426 } 425 427 426 428 func (p *Pages) Knots(w io.Writer, params KnotsParams) error { ··· 486 488 type NewRepoParams struct { 487 489 LoggedInUser *oauth.MultiAccountUser 488 490 Knots []string 491 + DefaultKnot string 489 492 } 490 493 491 494 func (p *Pages) NewRepo(w io.Writer, params NewRepoParams) error { ··· 496 499 LoggedInUser *oauth.MultiAccountUser 497 500 Knots []string 498 501 RepoInfo repoinfo.RepoInfo 502 + DefaultKnot string 499 503 } 500 504 501 505 func (p *Pages) ForkRepo(w io.Writer, params ForkRepoParams) error {

+28

appview/pages/templates/knots/index.html

··· 31 31 <div class="flex flex-col gap-6"> 32 32 {{ block "list" . }} {{ end }} 33 33 {{ block "register" . }} {{ end }} 34 + {{ block "default-knot" . }} {{ end }} 34 35 </div> 35 36 </section> 36 37 {{ end }} ··· 62 63 </section> 63 64 {{ end }} 64 65 66 + {{ define "default-knot" }} 67 + <section class="rounded w-full flex flex-col gap-2"> 68 + <h2 class="text-sm font-bold py-2 uppercase dark:text-gray-300">default knot</h2> 69 + <form hx-post="/profile/default-knot" class="col-span-1 md:col-span-1 md:justify-self-end group flex gap-2 items-stretch"> 70 + <select 71 + id="default-knot" 72 + name="default-knot" 73 + required 74 + class="p-1 max-w-64 border border-gray-200 bg-white dark:bg-gray-800 dark:text-white dark:border-gray-700"> 75 + {{/* For some reason, we can't use an empty string in a <select> in all scenarios unless it is preceded by a disabled select?? No idea, could just be a Firefox thing? */}} 76 + <option value="[[none]]" class="py-1" {{ if not $.DefaultKnot }}selected{{ end }}> 77 + Choose a default knot 78 + </option> 79 + {{ range $.AvailableKnots }} 80 + <option value="{{ . }}" class="py-1" {{ if eq . $.DefaultKnot }}selected{{ end }}> 81 + {{ . }} 82 + </option> 83 + {{ end }} 84 + </select> 85 + <button class="btn flex gap-2 items-center" type="submit"> 86 + {{ i "check" "size-4" }} 87 + {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} 88 + </button> 89 + </form> 90 + </section> 91 + {{ end }} 92 + 65 93 {{ define "register" }} 66 94 <section class="rounded w-full lg:w-fit flex flex-col gap-2"> 67 95 <h2 class="text-sm font-bold py-2 uppercase dark:text-gray-300">register a knot</h2>

+3 -1

appview/pages/templates/repo/fork.html

··· 25 25 value="{{ . }}" 26 26 class="mr-2" 27 27 id="domain-{{ . }}" 28 - {{if eq (len $.Knots) 1}}checked{{end}} 28 + {{if eq (len $.Knots) 1}}checked 29 + {{else if eq $.DefaultKnot . }}checked 30 + {{end}} 29 31 /> 30 32 <label for="domain-{{ . }}" class="dark:text-white">{{ . }}</label> 31 33 </div>

+3 -1

appview/pages/templates/repo/new.html

··· 155 155 class="mr-2" 156 156 id="domain-{{ . }}" 157 157 required 158 - {{if eq (len $.Knots) 1}}checked{{end}} 158 + {{if eq (len $.Knots) 1}}checked 159 + {{else if eq $.DefaultKnot . }}checked 160 + {{end}} 159 161 /> 160 162 <label for="domain-{{ . }}" class="dark:text-white lowercase">{{ . }}</label> 161 163 </div>

+10

appview/repo/repo.go

··· 1004 1004 return 1005 1005 } 1006 1006 1007 + defaultKnot := "" 1008 + knotPrefence, err := db.GetKnotPreference(rp.db, user.Did()) 1009 + if err != nil { 1010 + rp.logger.Warn("gettings users knot preferences", "error", err) 1011 + } 1012 + if knotPrefence != nil { 1013 + defaultKnot = knotPrefence.DefaultKnot 1014 + } 1015 + 1007 1016 rp.pages.ForkRepo(w, pages.ForkRepoParams{ 1008 1017 LoggedInUser: user, 1009 1018 Knots: knots, 1010 1019 RepoInfo: rp.repoResolver.GetRepoInfo(r, user), 1020 + DefaultKnot: defaultKnot, 1011 1021 }) 1012 1022 1013 1023 case http.MethodPost:

+23

appview/state/profile.go

··· 616 616 s.updateProfile(profile, w, r) 617 617 } 618 618 619 + func (s *State) UpdateDefaultKnotPreference(w http.ResponseWriter, r *http.Request) { 620 + err := r.ParseForm() 621 + if err != nil { 622 + log.Println("invalid preference update form", err) 623 + return 624 + } 625 + user := s.oauth.GetMultiAccountUser(r) 626 + 627 + defaultKnot := r.Form.Get("default-knot") 628 + 629 + if defaultKnot == "[[none]]" { // see pages/templates/knots/index.html for more info on why we use this value 630 + defaultKnot = "" 631 + } 632 + 633 + err = db.UpsertKnotPreference(s.db, user.Did(), defaultKnot) 634 + if err != nil { 635 + log.Println("failed to update default knot preference", err) 636 + return 637 + } 638 + 639 + s.pages.HxRefresh(w) 640 + } 641 + 619 642 func (s *State) updateProfile(profile *models.Profile, w http.ResponseWriter, r *http.Request) { 620 643 user := s.oauth.GetMultiAccountUser(r) 621 644 tx, err := s.db.BeginTx(r.Context(), nil)

appview/state/router.go

··· 165 165 r.Get("/edit-pins", s.EditPinsFragment) 166 166 r.Post("/bio", s.UpdateProfileBio) 167 167 r.Post("/pins", s.UpdateProfilePins) 168 + r.Post("/default-knot", s.UpdateDefaultKnotPreference) 168 169 }) 169 170 170 171 r.Mount("/settings", s.SettingsRouter())

+12

appview/state/state.go

··· 418 418 return 419 419 } 420 420 421 + knots = append(knots, "hello") 422 + 423 + defaultKnot := "" 424 + knotPrefence, err := db.GetKnotPreference(s.db, user.Did()) 425 + if err != nil { 426 + s.logger.Warn("gettings users knot preferences", "error", err) 427 + } 428 + if knotPrefence != nil { 429 + defaultKnot = knotPrefence.DefaultKnot 430 + } 431 + 421 432 s.pages.NewRepo(w, pages.NewRepoParams{ 422 433 LoggedInUser: user, 423 434 Knots: knots, 435 + DefaultKnot: defaultKnot, 424 436 }) 425 437 426 438 case http.MethodPost:

History

13 rounds 17 comments

willdot.net submitted #12 13d

diff interdiff

1 commit

expand

68d9f0b6

appview: allows a default knot to be configured

merge conflicts detected

expand

appview/db/db.go:596

expand 0 comments

willdot.net submitted #11 13d

diff interdiff

1 commit

expand

5618be13

appview: allows a default knot to be configured

expand 0 comments

willdot.net submitted #10 13d

diff interdiff

1 commit

expand

080125f9

appview: allows a default knot to be configured

expand 0 comments

willdot.net submitted #9 14d

diff interdiff

1 commit

expand

c81b80da

appview: allows a default knot to be configured

expand 0 comments

willdot.net submitted #8 14d

diff interdiff

1 commit

expand

ab57bdfc

appview: allow default knot to be saved as a preference and then used when creating a new repo

expand 0 comments

willdot.net submitted #7 6w

diff interdiff

1 commit

expand

361559b7

appview: allow default knot to be saved as a preference and then used when creating a new repo

expand 8 comments

oppi.li 19d

sorry for the late review! on the whole the code looks good. my only nit is with the model: we are storing the default knot as a string, but knot deletions can make this go out of sync. i think an FK relationship with the knot registrations table could fix this. we just unset defaults when a knot is deleted.

willdot.net 17d

That's a super valid point, didn't think of that!

I'll add a default value to empty string on the default_knot field, a foreign key constraint to the registrations table domain field since it's a unique field, and then ON DELETE SET DEFAULT so that if the knot gets deleted, the knot preference gets set to an empty string.

willdot.net 17d

That's a super valid point, didn't think of that!

oppi.li 16d

sure yeah that would work, we could cascade as well. either is fine i think.

willdot.net 16d

I thought about cascade but my understanding is that the knot_preference row for the user would be deleted if the knot is deleted.

If this is a preferences row for a user, there has potential for other things to be stored in that row which we may not want deleted on knot deletion.

oppi.li 16d

makes sense!

willdot.net 14d

Ok I've made these changes but I have had to do the cascade action on delete.

The reason for this is that the registrations table has a unique constraint on both the did and domain fields. The did is the user that is adding the registration, so that should be the user that is also creating the knot_preference row (which is also unique) and it can't be null.

Using the on delete set default therefor wouldn't work because the user_did field on the knot_preference can't be null.

So cascade is the only option.

willdot.net 14d

Although now I'm starting to doubt the design of the table. Perhaps it should be just for default knot preferences and thus named as that?

willdot.net submitted #6 6w

diff interdiff

1 commit

expand

10fdc2cf

appview: allow default knot to be saved as a preference and then used when creating a new repo

expand 0 comments

willdot.net submitted #5 6w

interdiff

1 commit

expand

8f3e1061

appview: allow default knot to be saved as a preference and then used when creating a new repo

expand 0 comments

willdot.net submitted #4 7w

diff interdiff

1 commit

expand

64142e65

appview: allows a default knot to be selected from knots available to the user

expand 5 comments

willdot.net 6w

@oppi.li While attempting to implement something else related to profiles, I've noticed that UpsertProfile(...) herehttps://tangled.org/tangled.org/core/blob/master/appview/db/profile.go#L133 also gets called as part of a JS ingester here https://tangled.org/tangled.org/core/blob/master/appview/ingester.go#L352 which means the DefaultKnot field will be overwritten with an empty string when a profile event is ingested. Am I understanding that correctly?

So instead I should probably not use the UpsertProfile(...) but use a smaller scoped function that just sets the Default Knot field?

oppi.li 6w

ah that is correct, the default knot will be overwritten by that call. i suppose that is one of the drawbacks of overloading models.Profile! instead of cloning UpsertProfile to add this as an exception, perhaps this is an indication that we need to avoid using the profile table/model for this. what do you think about creating a preferences table for stuff like this? we already have notification_preferences, we could do something similar for knots.

i see you have a PR open for punchcard work as well, which would fit quite well in a punchcard_preferences table.

willdot.net 6w

Yh I'm 100% down for using that approach. While I was implementing the punchcard PR I had this nagging feeling in me that this and other things belonged in some sort of separate "preferences" table so splitting them out into things like knot_preferences or punchcard_preferences is the right answer for me.

I'll redo that for this PR and then do the same of the other PR and hopefully it will prevent the merge conflicts I was dreading 🙈

oppi.li 6w

yeah! knot_preferences and punchcard_preferences seems okay for now. thanks for keeping at this by the way, and sorry for the slow review cycle!

willdot.net 6w

No worries! I don't expect immediate reviews 😁

I've refactored to use a new knot_preferences table for this PR. I had some merge conflicts with master though, so rebased that although took me a couple attempts to get everything nice and neat, hence so many rounds 🙈

willdot.net submitted #3 7w

diff interdiff

2 commits

expand

9a142873

appview: allows a default knot to be configured

7000e5e6

appview: allows a default knot to be selected from knots available to the user

expand 0 comments

willdot.net submitted #2 7w

diff interdiff

1 commit

expand

9a142873

appview: allows a default knot to be configured

expand 2 comments

oppi.li 7w

the code itself works pretty nicely now. so i've noticed a couple issues (apologies for not looking more closely earlier!):

the default-knot selector only iterates over knots that the user is an admin of, whereas they should be able to choose any knot that they are a member of as the default. you can use s.enforcer.GetKnotsForUser(...) to get a list of knots that a user has access to
the HTML change adds knot1.tangled.sh as an explicit case, this is not necessary if the above is implemented
the HTML template currently triggers a request when the select changes, could we make this more like how the spindle selector works? a form with a button to submit.

willdot.net 7w

I was looking for ages trying to find somewhere that did something similar. I don't use spindles so never saw that 🙈 A much better approach.

Also good shout on the knots for a user. Reading the code now, I understand what the registrations are now.

Anyhow, I've updated the PR and squashed everything so it should be good to test now.

Please note, that I have yet to figure out how to get multiple Knots running locally, and since I don't get knot1.tangled.sh locally I had to hard code some things in to test it worked, which is less than ideal.

willdot.net submitted #1 7w

diff interdiff

1 commit

expand

d48b01e5

appview: allows a default knot to be configured

expand 0 comments

willdot.net submitted #0 7w

diff

1 commit

expand

5ffb8261

appview: allows a default knot to be configured

expand 2 comments

oppi.li 7w

i get this error at runtime:

2026/01/20 04:58:12 profile err 5 values for 6 columns
2026/01/20 04:58:12 failed to update profile 5 values for 6 columns

this sql query is incorrect:

		`insert or replace into profile (
			did,
			description,
			include_bluesky,
			location,
			pronouns,
			default_knot
		)
		values (?, ?, ?, ?, ?)`,

there should be 6 ? placeholders!

willdot.net 7w

Ah crap, someone needs to create a lint tool that detects that 🤦‍♂️

Fixed.