tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages: remove @ from AtLink extension #909

merged opened by oppi.li targeting master from op/vtyvsnwqkrwr

we now prefer links with @. this change also moves the styling into the mention class entirely.

Signed-off-by: oppiliappan me@oppi.li

STACK 2
#910 appview/pages: use robust handle regex from indigo/syntax
3/3
0
#1
#909 appview/pages: remove @ from AtLink extension
1/3
0
#1
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3maihgf2bpe22
+3 -3
Diff #0
unified split
+2 -2
appview/pages/markup/extension/atlink.go
··· 87 88 func (r *atHtmlRenderer) renderAt(w util.BufWriter, source []byte, n ast.Node, entering bool) (ast.WalkStatus, error) { 89 if entering { 90 - w.WriteString(`<a href="/@`) 91 w.WriteString(n.(*AtNode).Handle) 92 - w.WriteString(`" class="mention font-bold">`) 93 } else { 94 w.WriteString("</a>") 95 }
··· 87 88 func (r *atHtmlRenderer) renderAt(w util.BufWriter, source []byte, n ast.Node, entering bool) (ast.WalkStatus, error) { 89 if entering { 90 + w.WriteString(`<a href="/`) 91 w.WriteString(n.(*AtNode).Handle) 92 + w.WriteString(`" class="mention">`) 93 } else { 94 w.WriteString("</a>") 95 }
+1 -1
input.css
··· 162 } 163 164 .prose a.mention { 165 - @apply no-underline hover:underline; 166 } 167 168 .prose li {
··· 162 } 163 164 .prose a.mention { 165 + @apply no-underline hover:underline font-bold; 166 } 167 168 .prose li {

History

2 rounds 0 comments
sign up or login to add to the discussion
oppi.li submitted #1
diff interdiff
1 commit
expand
026c207f
appview/pages: remove @ from AtLink extension
1/3 failed, 1/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
oppi.li submitted #0
1 commit
expand
a20d1dbe
appview/pages: remove @ from AtLink extension
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments