Monorepo for Tangled tangled.org

appview/pages : fix handle parsing false-positives #905

merged opened by regnault.dev targeting master from regnault.dev/core: issue/333
Labels

None yet.

assignee
Participants 2
AT URI
at://did:plc:fs3xpvrweneqrjgr7v2oow62/sh.tangled.repo.pull/3mahojtfoym22
Interdiff #1 โ†’ #2
appview/pages/markup/extension/atlink.go

This file has not been changed.

History

4 rounds 5 comments
sign up or login to add to the discussion
1 commit
expand
appview/pages : fix handle parsing false-positives
expand 5 comments

i have created https://tangled.org/tangled.org/core/pulls/910 to handle false positives, along with some tests. are there any cases that this PR handles and the other one does not? note that the linkify extension (provided by extensions.GFM) should run before the atlink extension for the test cases to work.

i can't say i am too familiar with the atlink extension (or goldmark extensions for that matter), @boltless.me would be the right person to review this code.

Yours seems to work with my test readme, I'll close this PR

Wait no, i'm studid, there's two cases that aren't taken into account in your branch:

[
@regnault.dev](https://regnault.dev)

[@regnault.dev](https://regnault.dev)

those are both great cases! i wonder if we are barking up the wrong tree by implementing this as a unique node, instead of having a pass at the html generation stage.

i say we keep this, but ill also incorporate my PR with the updated regex + tests!

pull request successfully merged
1 commit
expand
appview/pages : fix handle parsing false-positives
expand 0 comments
1 commit
expand
appview/pages : fix handle parsing false-positives
expand 0 comments
1 commit
expand
appview/pages : fix handle parsing false-positives
expand 0 comments