Signed-off-by: Seongmin Lee git@boltless.me
spindle/db/events.go
spindle/db/events.go
This file has not been changed.
+4
-7
spindle/engines/nixery/engine.go
+4
-7
spindle/engines/nixery/engine.go
···
179
179
return err
180
180
}
181
181
e.registerCleanup(wid, func(ctx context.Context) error {
182
-
err := e.docker.NetworkRemove(ctx, networkName(wid))
183
-
if err != nil {
182
+
if err := e.docker.NetworkRemove(ctx, networkName(wid)); err != nil {
184
183
return fmt.Errorf("removing network: %w", err)
185
184
}
186
185
return nil
···
233
232
return fmt.Errorf("creating container: %w", err)
234
233
}
235
234
e.registerCleanup(wid, func(ctx context.Context) error {
236
-
err := e.docker.ContainerStop(ctx, resp.ID, container.StopOptions{})
237
-
if err != nil {
235
+
if err := e.docker.ContainerStop(ctx, resp.ID, container.StopOptions{}); err != nil {
238
236
return fmt.Errorf("stopping container: %w", err)
239
237
}
240
238
241
-
err = e.docker.ContainerRemove(ctx, resp.ID, container.RemoveOptions{
239
+
err := e.docker.ContainerRemove(ctx, resp.ID, container.RemoveOptions{
242
240
RemoveVolumes: true,
243
241
RemoveLinks: false,
244
242
Force: false,
···
249
247
return nil
250
248
})
251
249
252
-
err = e.docker.ContainerStart(ctx, resp.ID, container.StartOptions{})
253
-
if err != nil {
250
+
if err := e.docker.ContainerStart(ctx, resp.ID, container.StartOptions{}); err != nil {
254
251
return fmt.Errorf("starting container: %w", err)
255
252
}
256
253
spindle/server.go
spindle/server.go
This file has not been changed.
History
7 rounds
1 comment
boltless.me
submitted
#6
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
pull request successfully merged
boltless.me
submitted
#5
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#3
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 1 comment
boltless.me
submitted
#0
1 commit
expand
collapse
spindle: more verbose error messages
Signed-off-by: Seongmin Lee <git@boltless.me>
lgtm, though i think we can compress statements of the form:
into:
as long as the subexpression is small (not necessary for this PR!).