Monorepo for Tangled tangled.org

spindle/models: use full at-uri for TANGLED_PIPELINE_ID #886

merged opened by boltless.me targeting master from sl/okmkyytolvko

rkey itself isn't unique across the network because multiple different knots can emit same rkey. We should use full at-uri here instead.

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m7zmleuosk22
+1 -1
Diff #6
+1 -1
spindle/models/pipeline_env.go
··· 20 // Standard CI environment variable 21 env["CI"] = "true" 22 23 - env["TANGLED_PIPELINE_ID"] = pipelineId.Rkey 24 25 // Repo info 26 if tr.Repo != nil {
··· 20 // Standard CI environment variable 21 env["CI"] = "true" 22 23 + env["TANGLED_PIPELINE_ID"] = pipelineId.AtUri().String() 24 25 // Repo info 26 if tr.Repo != nil {

History

7 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 1 comment
1 commit
expand
spindle/models: use full at-uri for TANGLED_PIPELINE_ID
3/3 success
expand
expand 0 comments