tangled.org / core

Monorepo for Tangled tangled.org

appview: remove `ResolvedRepo` for eternity #821

merged opened by

boltless.me 3 months ago targeting master from sl/yurolxtlpsmz

Signed-off-by: Seongmin Lee git@boltless.me

STACK 11

#821 appview: remove ResolvedRepo for eternity

#820 appview: remove use of all fields under ResolvedRepo

#812 appview: prefer models.Repo over ResolvedRepo internally

#811 appview/pages: fix pages.RepoComparedDiffFragment()

#810 appview: use less RepoInfo for ResolvedRepo

#809 appview: remove ResolvedRepo.RolesInRepo()

#808 appview: diet the reporesolver

#807 appview: remove unused fields on RepoInfo

#802 appview: use less OwnerSlashRepo() in handlers

#801 appview/pages: resolve did on render

#806 appview/db: remove unused struct

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m5t2gtxrpi22

+1 -1

15 changed files

Interdiff #1 → #2

expand all

appview

issues

issues.go

opengraph.go

middleware

middleware.go

pulls

opengraph.go

pulls.go

repo

artifact.go

blob.go

feed.go

index.go

log.go

opengraph.go

repo.go

settings.go

tree.go

reporesolver

resolver.go

appview/issues/issues.go

This file has not been changed.

appview/issues/opengraph.go

This file has not been changed.

appview/middleware/middleware.go

This file has not been changed.

appview/pulls/opengraph.go

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

appview/repo/artifact.go

This file has not been changed.

appview/repo/blob.go

This file has not been changed.

appview/repo/feed.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/log.go

This file has not been changed.

appview/repo/opengraph.go

This file has not been changed.

appview/repo/repo.go

This file has not been changed.

appview/repo/settings.go

This file has not been changed.

appview/repo/tree.go

This file has not been changed.

+1 -1

appview/reporesolver/resolver.go

··· 53 53 54 54 // 1. [x] replace `RepoInfo` to `reporesolver.GetRepoInfo(r *http.Request, repo, user)` 55 55 // 2. [x] remove `rr`, `CurrentDir`, `Ref` fields from `ResolvedRepo` 56 - // 3. [ ] remove `ResolvedRepo` 56 + // 3. [x] remove `ResolvedRepo` 57 57 // 4. [ ] replace reporesolver to reposervice 58 58 func (rr *RepoResolver) GetRepoInfo(r *http.Request, user *oauth.User) repoinfo.RepoInfo { 59 59 ownerId, ook := r.Context().Value("resolvedId").(identity.Identity)

History

3 rounds 3 comments

sign up or login to add to the discussion

boltless.me submitted #2 3mo

diff

1 commit

expand

cdc4ebf7

appview: remove ResolvedRepo for eternity

expand 1 comment

oppi.li 3mo

entire stack lgtm, thanks for the hard work on this!

pull request successfully merged

boltless.me submitted #1 3mo

1 commit

expand

c28eb3c3

appview: remove ResolvedRepo for eternity

expand 1 comment

oppi.li 3mo

entire stack lgtm, thanks for the hard work on this!

boltless.me submitted #0 3mo

diff

1 commit

expand

e5fcb607

appview: remove ResolvedRepo for eternity

expand 1 comment

boltless.me 3mo

@oppi.li (testing the at-mention) this stack is ready for review. basically all I did here are:

diet the repoResolver so we can switch to repo service later (see #800)
remove ResolvedRepo

Because the dependencies are quite tangled and ResolvedRepo was used all over the place, I had to divide the change in multiple steps and migrated gradually.