Monorepo for Tangled tangled.org

appview: remove ResolvedRepo for eternity #821

merged opened by boltless.me targeting master from sl/yurolxtlpsmz
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m5t2gtxrpi22
+6 -6
Interdiff #0 #1
+6 -6
appview/issues/issues.go
··· 810 811 labelDefs, err := db.GetLabelDefinitions( 812 rp.db, 813 - db.FilterIn("at_uri", f.Labels), 814 db.FilterContains("scope", tangled.RepoIssueNSID), 815 ) 816 if err != nil { ··· 827 828 labelDefs, err := db.GetLabelDefinitions( 829 rp.db, 830 - db.FilterIn("at_uri", f.Repo.Labels), 831 db.FilterContains("scope", tangled.RepoIssueNSID), 832 ) 833 if err != nil { ··· 860 Open: true, 861 Did: user.Did, 862 Created: time.Now(), 863 - Repo: f, 864 } 865 866 if err := rp.validator.ValidateIssue(issue); err != nil { ··· 878 Open: true, 879 Did: user.Did, 880 Created: time.Now(), 881 - Repo: &f.Repo, 882 } 883 884 if err := rp.validator.ValidateIssue(issue); err != nil { ··· 939 } 940 rp.notifier.NewIssue(r.Context(), issue, mentions) 941 942 - ownerSlashRepo := reporesolver.GetBaseRepoPath(r, f) 943 rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId)) 944 return 945 } ··· 957 } 958 rp.notifier.NewIssue(r.Context(), issue, mentions) 959 960 - ownerSlashRepo := reporesolver.GetBaseRepoPath(r, &f.Repo) 961 rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId)) 962 return 963 }
··· 810 811 labelDefs, err := db.GetLabelDefinitions( 812 rp.db, 813 + db.FilterIn("at_uri", f.Repo.Labels), 814 db.FilterContains("scope", tangled.RepoIssueNSID), 815 ) 816 if err != nil { ··· 827 828 labelDefs, err := db.GetLabelDefinitions( 829 rp.db, 830 + db.FilterIn("at_uri", f.Labels), 831 db.FilterContains("scope", tangled.RepoIssueNSID), 832 ) 833 if err != nil { ··· 860 Open: true, 861 Did: user.Did, 862 Created: time.Now(), 863 + Repo: &f.Repo, 864 } 865 866 if err := rp.validator.ValidateIssue(issue); err != nil { ··· 878 Open: true, 879 Did: user.Did, 880 Created: time.Now(), 881 + Repo: f, 882 } 883 884 if err := rp.validator.ValidateIssue(issue); err != nil { ··· 939 } 940 rp.notifier.NewIssue(r.Context(), issue, mentions) 941 942 + ownerSlashRepo := reporesolver.GetBaseRepoPath(r, &f.Repo) 943 rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId)) 944 return 945 } ··· 957 } 958 rp.notifier.NewIssue(r.Context(), issue, mentions) 959 960 + ownerSlashRepo := reporesolver.GetBaseRepoPath(r, f) 961 rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", ownerSlashRepo, issue.IssueId)) 962 return 963 }
appview/issues/opengraph.go

This file has not been changed.

appview/middleware/middleware.go

This file has not been changed.

appview/pulls/opengraph.go

This file has not been changed.

appview/pulls/pulls.go

This patch was likely rebased, as context lines do not match.

appview/repo/artifact.go

This file has not been changed.

appview/repo/blob.go

This file has not been changed.

appview/repo/feed.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/log.go

This file has not been changed.

appview/repo/opengraph.go

This file has not been changed.

appview/repo/repo.go

This file has not been changed.

appview/repo/settings.go

This file has not been changed.

appview/repo/tree.go

This file has not been changed.

appview/reporesolver/resolver.go

This file has not been changed.

History

3 rounds 3 comments
sign up or login to add to the discussion
1 commit
expand
appview: remove ResolvedRepo for eternity
expand 1 comment

entire stack lgtm, thanks for the hard work on this!

pull request successfully merged
1 commit
expand
appview: remove ResolvedRepo for eternity
expand 1 comment

entire stack lgtm, thanks for the hard work on this!

1 commit
expand
appview: remove ResolvedRepo for eternity
expand 1 comment

@oppi.li (testing the at-mention) this stack is ready for review. basically all I did here are:

  • diet the repoResolver so we can switch to repo service later (see #800)
  • remove ResolvedRepo

Because the dependencies are quite tangled and ResolvedRepo was used all over the place, I had to divide the change in multiple steps and migrated gradually.