Monorepo for Tangled tangled.org

appview/state/router: add pagination middleware to good first issues route #799

merged opened by

willdot.net 3 months ago targeting master from [deleted fork]: gfi-paging

Noticed that paging wasn't working on the good first issues page and after digging around to see how other pages use pagination I noticed that the GFI route wasn't using the paging middleware.

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:dadhhalkfcq3gucaq25hjqon/sh.tangled.repo.pull/3m5jyydyef522

+1 -1

1 changed file

Diff round #0

expand all

unified split

appview

state

router.go

+1 -1

appview/state/router.go

··· 139 // r.Post("/import", s.ImportRepo) 140 }) 141 142 - r.Get("/goodfirstissues", s.GoodFirstIssues) 143 144 r.With(middleware.AuthMiddleware(s.oauth)).Route("/follow", func(r chi.Router) { 145 r.Post("/", s.Follow)

··· 139 // r.Post("/import", s.ImportRepo) 140 }) 141 142 + r.With(middleware.Paginate).Get("/goodfirstissues", s.GoodFirstIssues) 143 144 r.With(middleware.AuthMiddleware(s.oauth)).Route("/follow", func(r chi.Router) { 145 r.Post("/", s.Follow)

History

1 round 1 comment

willdot.net submitted #0 3mo

1 commit

expand

4e4f0af4

appview/state/router: add pagination middleware to good first issues route

expand 1 comment

oppi.li 3mo

lgtm thanks!

pull request successfully merged