Noticed that paging wasn't working on the good first issues page and after digging around to see how other pages use pagination I noticed that the GFI route wasn't using the paging middleware.
+1
-1
appview/state/router.go
+1
-1
appview/state/router.go
···
139
139
// r.Post("/import", s.ImportRepo)
140
140
})
141
141
142
-
r.Get("/goodfirstissues", s.GoodFirstIssues)
142
+
r.With(middleware.Paginate).Get("/goodfirstissues", s.GoodFirstIssues)
143
143
144
144
r.With(middleware.AuthMiddleware(s.oauth)).Route("/follow", func(r chi.Router) {
145
145
r.Post("/", s.Follow)
History
1 round
1 comment
willdot.net
submitted
#0
1 commit
expand
collapse
4e4f0af4
appview/state/router: add pagination middleware to good first issues route
Signed-off-by: Will Andrews <did:plc:dadhhalkfcq3gucaq25hjqon>
expand 1 comment
pull request successfully merged
lgtm thanks!