Monorepo for Tangled tangled.org

draft: render backlinks #765

merged opened by boltless.me targeting master from feat/mentions
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4ya772l5c22
+4 -1
Interdiff #7 โ†’ #8
appview/db/pulls.go

This file has not been changed.

appview/db/reference.go

This file has not been changed.

+3
appview/issues/issues.go
··· 164 164 newIssue := issue 165 165 newIssue.Title = r.FormValue("title") 166 166 newIssue.Body = r.FormValue("body") 167 + newIssue.Mentions, newIssue.References = rp.refResolver.Resolve(r.Context(), newIssue.Body) 167 168 168 169 if err := rp.validator.ValidateIssue(newIssue); err != nil { 169 170 l.Error("validation error", "err", err) ··· 600 601 newComment := comment 601 602 newComment.Body = newBody 602 603 newComment.Edited = &now 604 + newComment.Mentions, newComment.References = rp.refResolver.Resolve(r.Context(), newBody) 605 + 603 606 record := newComment.AsRecord() 604 607 605 608 tx, err := rp.db.Begin()
+1 -1
appview/models/pull.go
··· 108 108 Body: &p.Body, 109 109 Mentions: mentions, 110 110 References: references, 111 - CreatedAt: p.Created.Format(time.RFC3339), 111 + CreatedAt: p.Created.Format(time.RFC3339), 112 112 Target: &tangled.RepoPull_Target{ 113 113 Repo: p.RepoAt.String(), 114 114 Branch: p.TargetBranch,
appview/models/reference.go

This file has not been changed.

appview/pages/pages.go

This file has not been changed.

appview/pages/templates/repo/fragments/backlinks.html

This file has not been changed.

appview/pages/templates/repo/issues/issue.html

This file has not been changed.

appview/pages/templates/repo/pulls/pull.html

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

History

12 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
appview: backlinks
expand 1 comment

tested this locally: and all edge cases i can think of are handled pretty well! the rendering of backlinks also looks good. thanks for the brilliant work on this!

pull request successfully merged
1 commit
expand
appview: backlinks
expand 0 comments
1 commit
expand
appview: backlinks
expand 0 comments
1 commit
expand
appview: backlinks
expand 0 comments
1 commit
expand
appview: backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments
1 commit
expand
draft: render backlinks
expand 0 comments