Monorepo for Tangled tangled.org

appview,lexicons: atprotate the mentions & references #761

merged opened by boltless.me targeting master from feat/mentions

Storing references parsed from the markdown body in atproto record and DB. There can be lots of reference types considering the from/to types so storing both as AT-URIs

Using sql.Tx more to combine multiple DB query to single recoverable operation.

Note: Pulls don't have mentinos/references yet

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4vklvknse22
+4 -4
Interdiff #11 #12
api/tangled/cbor_gen.go

This file has not been changed.

api/tangled/issuecomment.go

This file has not been changed.

api/tangled/pullcomment.go

This file has not been changed.

api/tangled/repoissue.go

This file has not been changed.

api/tangled/repopull.go

This file has not been changed.

appview/db/db.go

This file has not been changed.

appview/db/issues.go

This file has not been changed.

appview/db/pulls.go

This file has not been changed.

appview/db/reference.go

This file has not been changed.

appview/ingester.go

This file has not been changed.

appview/issues/issues.go

This patch was likely rebased, as context lines do not match.

appview/models/issue.go

This file has not been changed.

appview/models/pull.go

This file has not been changed.

+4 -4
appview/pulls/pulls.go
··· 720 720 return 721 721 } 722 722 723 - mentions, _ := s.refResolver.Resolve(r.Context(), body) 723 + mentions, references := s.refResolver.Resolve(r.Context(), body) 724 724 725 725 // Start a transaction 726 726 tx, err := s.db.BeginTx(r.Context(), nil) ··· 735 735 return 736 736 } 737 737 738 - mentions, references := s.refResolver.Resolve(r.Context(), body) 738 + mentions, _ := s.refResolver.Resolve(r.Context(), body) 739 739 740 740 // Start a transaction 741 741 tx, err := s.db.BeginTx(r.Context(), nil) ··· 764 764 Body: body, 765 765 CommentAt: atResp.Uri, 766 766 SubmissionId: pull.Submissions[roundNumber].ID, 767 + Mentions: mentions, 768 + References: references, 767 769 } 768 770 769 771 // Create the pull comment in the database with the commentAt field ··· 779 781 Body: body, 780 782 CommentAt: atResp.Uri, 781 783 SubmissionId: pull.Submissions[roundNumber].ID, 782 - Mentions: mentions, 783 - References: references, 784 784 } 785 785 786 786 // Create the pull comment in the database with the commentAt field
appview/refresolver/resolver.go

This file has not been changed.

lexicons/issue/comment.json

This file has not been changed.

lexicons/issue/issue.json

This file has not been changed.

lexicons/pulls/comment.json

This file has not been changed.

lexicons/pulls/pull.json

This file has not been changed.

History

13 rounds 0 comments
sign up or login to add to the discussion
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 failed
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview,lexicons: atprotate the mentions & references
1/3 failed, 2/3 running
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 failed
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
1/3 failed, 2/3 timeout
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
1/3 failed, 2/3 timeout
expand
expand 0 comments
1 commit
expand
appview,lexicons: atprotate the mentions & references
3/3 success
expand
expand 0 comments