tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages: add external link panel to pulls #755

merged opened by oppi.li targeting master from push-toykwqpnvqrs
STACK 4
#755 appview/pages: add external link panel to pulls
3/3
2
#1
#754 appview/pages: add external link panel to issues
3/3
0
#1
#753 appview/pages: add panel to link an ATURI on pdsls
3/3
0
#1
#752 appview/models: rename Pull.PullAt() to Pull.AtUri()
3/3
0
#1
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3m4s5ukqusw22
+1
Diff #1
+1
appview/pages/templates/repo/pulls/pull.html
··· 21 21 "Subject" $.Pull.AtUri 22 22 "State" $.Pull.Labels) }} 23 23 {{ template "repo/fragments/participants" $.Pull.Participants }} 24 + {{ template "repo/fragments/externalLinkPanel" $.Pull.AtUri }} 24 25 </div> 25 26 </div> 26 27 {{ end }}

History

2 rounds 2 comments
sign up or login to add to the discussion
oppi.li submitted #1
interdiff
1 commit
expand
1d8e9ac4
appview/pages: add external link panel to pulls
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
oppi.li submitted #0
diff
1 commit
expand
d75ce20a
appview/pages: add external link panel to pulls
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 2 comments
boltless.me

not sure I like this. Sure, PDSls is useful and I use it when I inspect the atproto objects, but showing it as a default way to inspect records seems... quite biased. Maybe add "copy as aturi" button can be a more neutral solution.

I won't be that upset if this get merged, but just saying this seems a bit biased to me.

oppi.li

agree that copy is useful. IMO it would still be nice to introspect the data itself, and i personally do love PDSls. i have changed the panel design a bit to allow both, and to put the text content of the ATURI up front.