Monorepo for Tangled tangled.org

appview: add user_mentioned notification preference option #744

merged opened by boltless.me targeting master from feat/mentions
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4ptmv4kgp22
+7 -7
Interdiff #2 #3
+7 -7
appview/db/db.go
··· 1113 1113 return err 1114 1114 }) 1115 1115 1116 - runMigration(conn, logger, "add-usermentioned-preference", func(tx *sql.Tx) error { 1117 - _, err := tx.Exec(` 1118 - alter table notification_preferences add column user_mentioned integer not null default 1; 1119 - `) 1120 - return err 1121 - }) 1122 - 1123 1116 return &DB{ 1124 1117 db, 1125 1118 logger, 1126 1119 1127 1120 1121 + return err 1122 + }) 1123 + 1124 + runMigration(conn, logger, "add-usermentioned-preference", func(tx *sql.Tx) error { 1125 + _, err := tx.Exec(` 1126 + alter table notification_preferences add column user_mentioned integer not null default 1; 1127 + `) 1128 1128 return err 1129 1129 }) 1130 1130
appview/db/notifications.go

This patch was likely rebased, as context lines do not match.

appview/models/notifications.go

This file has not been changed.

appview/pages/templates/user/settings/notifications.html

This file has not been changed.

appview/settings/settings.go

This file has not been changed.

History

9 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
2/3 failed, 1/3 success
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
2/3 failed, 1/3 running
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
1/3 failed, 2/3 timeout
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 0 comments
1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 1 comment

stack lgtm, can we make the modification to notify only upto 5 users per comment? the rest should be ignored. could be useful as a spam prevention technique.

1 commit
expand
appview: add user_mentioned notification preference option
3/3 success
expand
expand 0 comments