tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: use correct actor on issue/pr state change events #740

merged opened by boltless.me targeting master from feat/mentions
STACK 4
#765 draft: render backlinks
3/3
1
#11
#764 appview/pages: fix broken issue-comment links
0/3
0
#11
#761 appview,lexicons: atprotate the mentions & references
0/3
0
#12
#760 appview: parse reference links from markdown body
0/3
0
#12
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4ksdieshw22
+3 -3
Interdiff #1 → #2
unified split
appview/indexer/notifier.go

This file has not been changed.

appview/issues/issues.go

This file has not been changed.

appview/notify/db/db.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

+3 -3
appview/notify/notifier.go
··· 50 50 func (m *BaseNotifier) NewFollow(ctx context.Context, follow *models.Follow) {} 51 51 func (m *BaseNotifier) DeleteFollow(ctx context.Context, follow *models.Follow) {} 52 52 53 - func (m *BaseNotifier) NewPull(ctx context.Context, pull *models.Pull) {} 54 - func (m *BaseNotifier) NewPullComment(ctx context.Context, models *models.PullComment) {} 55 - func (m *BaseNotifier) NewPullState(ctx context.Context, actor syntax.DID, pull *models.Pull) {} 53 + func (m *BaseNotifier) NewPull(ctx context.Context, pull *models.Pull) {} 54 + func (m *BaseNotifier) NewPullComment(ctx context.Context, models *models.PullComment) {} 55 + func (m *BaseNotifier) NewPullState(ctx context.Context, actor syntax.DID, pull *models.Pull) {} 56 56 57 57 func (m *BaseNotifier) UpdateProfile(ctx context.Context, profile *models.Profile) {} 58 58
appview/notify/posthog/notifier.go

This file has not been changed.

appview/pulls/pulls.go

This file has not been changed.

History

5 rounds 1 comment
sign up or login to add to the discussion
boltless.me submitted #4
diff interdiff
1 commit
expand
31ca092c
appview/notify: use correct actor on issue/pr state change events
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #3
diff interdiff
1 commit
expand
31ca092c
appview/notify: use correct actor on issue/pr state change events
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #2
diff
1 commit
expand
a810c40a
appview/notify: use correct actor on issue/pr state change events
1/3 failed, 1/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
cd1d89b2
appview/notify: use correct actor on issue/pr state change events
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
3d18fe3a
appview/notify: use correct actor on issue/pr state change events
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li

this is valuable as an interim fix! as you know, we are looking to atprotate issue state and PR state changes.

can you move this off of this stack? can be opened as a standalone PR.