tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/models: add NotificationTypeUserMentioned notif type #737

merged opened by boltless.me targeting master from feat/mentions
STACK 4
#765 draft: render backlinks
3/3
1
#11
#764 appview/pages: fix broken issue-comment links
0/3
0
#11
#761 appview,lexicons: atprotate the mentions & references
0/3
0
#12
#760 appview: parse reference links from markdown body
0/3
0
#12
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4jbido5pf22
+7
Diff #2
unified split
+5
appview/models/notifications.go
··· 20 NotificationTypeIssueReopen NotificationType = "issue_reopen" 21 NotificationTypePullClosed NotificationType = "pull_closed" 22 NotificationTypePullReopen NotificationType = "pull_reopen" 23 ) 24 25 type Notification struct { ··· 63 return "git-pull-request-create" 64 case NotificationTypeFollowed: 65 return "user-plus" 66 default: 67 return "" 68 } ··· 113 return prefs.PullCreated // same pref for now 114 case NotificationTypeFollowed: 115 return prefs.Followed 116 default: 117 return false 118 }
··· 20 NotificationTypeIssueReopen NotificationType = "issue_reopen" 21 NotificationTypePullClosed NotificationType = "pull_closed" 22 NotificationTypePullReopen NotificationType = "pull_reopen" 23 + NotificationTypeUserMentioned NotificationType = "user_mentioned" 24 ) 25 26 type Notification struct { ··· 64 return "git-pull-request-create" 65 case NotificationTypeFollowed: 66 return "user-plus" 67 + case NotificationTypeUserMentioned: 68 + return "message-square" 69 default: 70 return "" 71 } ··· 116 return prefs.PullCreated // same pref for now 117 case NotificationTypeFollowed: 118 return prefs.Followed 119 + case NotificationTypeUserMentioned: 120 + return true // always notify on mention 121 default: 122 return false 123 }
+2
appview/pages/templates/notifications/fragments/item.html
··· 54 reopened a pull request 55 {{ else if eq .Type "followed" }} 56 followed you 57 {{ else }} 58 {{ end }} 59 {{ end }}
··· 54 reopened a pull request 55 {{ else if eq .Type "followed" }} 56 followed you 57 + {{ else if eq .Type "user_mentioned" }} 58 + mentioned you 59 {{ else }} 60 {{ end }} 61 {{ end }}

History

14 rounds 1 comment
sign up or login to add to the discussion
boltless.me submitted #13
diff interdiff
1 commit
expand
8d825910
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
boltless.me submitted #12
diff interdiff
1 commit
expand
8d825910
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #11
diff interdiff
1 commit
expand
8d825910
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #10
diff interdiff
1 commit
expand
288d7a40
appview/models: add NotificationTypeUserMentioned notif type
1/3 failed, 2/3 running
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #9
diff interdiff
1 commit
expand
1e891d5c
appview/models: add NotificationTypeUserMentioned notif type
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #8
diff interdiff
1 commit
expand
7fbdba9c
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
4b5da426
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
4b5da426
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
1ff954cd
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
76cf6de7
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
81434a60
appview/models: add NotificationTypeUserMentioned notif type
1/3 failed, 1/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #2
interdiff
1 commit
expand
0e01a114
appview/models: add NotificationTypeUserMentioned notif type
1/3 failed, 2/3 timeout
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
3bafb560
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li

can i suggest that we use the https://lucide.dev/icons/at-sign icon?

additionally: why not introduce a preference for mentions? users could choose to ignore mentions if need be.

boltless.me submitted #0
diff
1 commit
expand
3bafb560
appview/models: add NotificationTypeUserMentioned notif type
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments