Monorepo for Tangled tangled.org

knotserver: redirect handle-path to did-path #705

merged opened by boltless.me targeting master from push-xpolynpvotzt

fixing issue reported on discord: https://discord.com/channels/1361963801993285692/1361966362653757450/1430609124114301060

knotserver: redirect handle-path to did-path

this will allow handle based url when cloning from knot over https
usually appview will resolve this before redirecting to the knot

this implementation just redirects to resolved path instead of passing
the entire identity for performance. As we won't want to resolve same
identity twice when proxied by appview.

Signed-off-by: Seongmin Lee <git@boltless.me>
Labels
bugfix
assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3sj67z25x22
Interdiff #1 โ†’ #2
knotserver/router.go

This patch was likely rebased, as context lines do not match.

History

3 rounds 6 comments
sign up or login to add to the discussion
1 commit
expand
knotserver: redirect handle-path to did-path
3/3 success
expand
expand 3 comments

will give this a test locally; but that being said, the knotserver need not provide the full API layer that the appview provides. but IMO this one is pretty nice to have (maybe we want all the rerouting rules in that case?).

oops wrong PR, can't remove the comment yet.

pull request successfully merged
1 commit
expand
knotserver: redirect handle-path to did-path
3/3 failed
expand
expand 1 comment

ready for review! tested https-clone, ssh-clone, ssh-push all still working fine.

1 commit
expand
knotserver: redirect handle-path to did-path
expand 2 comments

...I hate markdown

ah wait, this doesn't work