Monorepo for Tangled tangled.org

appvieww: make default label defs configurable #703

merged opened by boltless.me targeting master from sandboxed-atmosphere

hard-coded labels make hard to setup local sandboxed environment as the appview won't run until we fill all 5 definitions under TangledDid.

so make them configurable with TANGLED_LABEL_DEFAULTS which is a list of aturis delimitted by , character

we can have any number/kind of default labels but gfi is required for /good-first-issue page

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3sa6t262p22
+1 -1
Interdiff #6 #7
+1 -1
appview/config/config.go
··· 79 79 } 80 80 81 81 type LabelConfig struct { 82 - DefaultLabelDefs []string `env:"DEFAULTS"` // delimiter=, 82 + DefaultLabelDefs []string `env:"DEFAULTS, default=at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/wontfix,at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/good-first-issue,at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/duplicate,at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/documentation,at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/assignee"` // delimiter=, 83 83 GoodFirstIssue string `env:"GFI, default=at://did:plc:wshs7t2adsemcrrd4snkeqli/sh.tangled.label.definition/good-first-issue"` 84 84 } 85 85
appview/models/label.go

This file has not been changed.

appview/repo/repo.go

This file has not been changed.

appview/state/gfi.go

This file has not been changed.

appview/state/state.go

This file has not been changed.

History

8 rounds 3 comments
sign up or login to add to the discussion
1 commit
expand
appview: make default label defs configurable
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview: make default label defs configurable
3/3 success
expand
expand 2 comments

the default here should be the previously configured 5 label ATURIs.

I didn't included it because I thought it would be bit too long to inline as struct tags. resubmitted.

1 commit
expand
appview: make default label defs configurable
3/3 success
expand
expand 0 comments
1 commit
expand
appview: make default label defs configurable
expand 0 comments
1 commit
expand
appview: make default label defs configurable
expand 1 comment

can we remove some of the debug logging in this change?

1 commit
expand
appview: make default label defs configurable
expand 0 comments
1 commit
expand
appview: make default label defs configurable
expand 0 comments
1 commit
expand
appvieww: make default label defs configurable
expand 0 comments