tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/gfi: render gfi label when there isn't any matching issues #702

merged opened by boltless.me targeting master from sandboxed-atmosphere

although it might not happen, the appview should be able to handle when there is no single issue with good-first-issue label

Signed-off-by: Seongmin Lee git@boltless.me

STACK 6
#768 local-infra: local, sandboxed atmosphere infra
1
#0
#701 nix/vm: make vm more configurable
0
#8
#700 nix: knot: pass config to knot guard
0
#8
#699 nix: add plcUrl options for services.{knot,spindle}
0
#8
#698 Revert "Revert "*/config: add PLC URL config option""
0
#8
#704 appview/oauth: support custom PLC directory
0
#8
ABANDONED PULLS 1
#718 local-infra: support https scheme for knot
0
#0
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3sa6t262h22
+1 -1
Interdiff #2 → #3
unified split
+1 -1
appview/state/gfi.go
··· 28 gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) 29 if err != nil { 30 log.Println("failed to get gfi label def", err) 31 - s.pages.Error503(w) 32 return 33 } 34
··· 28 gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) 29 if err != nil { 30 log.Println("failed to get gfi label def", err) 31 + s.pages.Error500(w) 32 return 33 } 34

History

8 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #7
diff interdiff
1 commit
expand
41dcabc7
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
pull request successfully merged
boltless.me submitted #6
diff interdiff
1 commit
expand
41dcabc7
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
41dcabc7
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
41dcabc7
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
boltless.me submitted #3
diff
1 commit
expand
1a7739de
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
118f19c0
appview/gfi: render gfi label when there isn't any matching issues
expand 2 comments
anirudh.fi

The error code here should probably be a 500.

boltless.me

applied

boltless.me submitted #1
diff interdiff
1 commit
expand
118f19c0
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
c3c678b6
appview/gfi: render gfi label when there isn't any matching issues
expand 0 comments