Monorepo for Tangled tangled.org

appview/indexer: handle NewIssueClosed #695

merged opened by boltless.me targeting master from boltless.me/core: feat/search

Doesn't suport issue reopen yet

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3q47rjacn22
+8
Interdiff #1 #2
appview/indexer/notifier.go

This file has not been changed.

+8
appview/issues/issues.go
··· 305 305 rp.pages.Notice(w, "issue-action", "Failed to close issue. Try again later.") 306 306 return 307 307 } 308 + // change the issue state (this will pass down to the notifiers) 309 + issue.Open = false 308 310 309 311 // notify about the issue closure 310 312 rp.notifier.NewIssueClosed(r.Context(), issue) ··· 353 355 rp.pages.Notice(w, "issue-action", "Failed to reopen issue. Try again later.") 354 356 return 355 357 } 358 + // notify about the issue closure 359 + issue.Open = true 360 + 361 + // // notify about the issue reopen 362 + // rp.notifier.NewIssueReopen(r.Context(), issue) 363 + 356 364 rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId)) 357 365 return 358 366 } else {

History

10 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
pull request successfully merged
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments
1 commit
expand
appview/indexer: handle NewIssueClosed
expand 1 comment

not entirely sure how bleve works when updating indices, but from a preliminary testing, this does not seem to work as expected. an issue that was closed still shows up in the search results, when searching open issues..

1 commit
expand
appview/indexer: handle NewIssueClosed
expand 0 comments