tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: pass logger with mergedLogger #693

merged opened by boltless.me targeting master from boltless.me/core: feat/search
STACK 13
#711 appview/notify: merge NewPullClosed/Merged/Reopen to NewPullState
1
#6
#710 appview: add pull_reopen event
0
#6
#709 appview/pulls: add search endpoint
0
#6
#708 appview/indexer: add pulls indexer
0
#6
#707 appview: add issue_reopen event
0
#6
#706 appview/indexer: put bleve index dir under indexes/ dir
0
#6
#693 appview/notify: pass logger with mergedLogger
2
#9
#695 appview/indexer: handle NewIssueClosed
1
#9
#694 appview/notify: add DeleteIssue event
1
#9
#496 appview: add issue search endpoint
5
#13
#495 wip: add indexer mappings
1
#14
#494 appview: add basic issue indexer (wip)
2
#14
#685 go.mod: add bleve as a dependency
1
#10
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m3q47rjacq22
Interdiff #6 → #7
unified split
appview/indexer/notifier.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/state/state.go

This file has not been changed.

History

10 rounds 2 comments
sign up or login to add to the discussion
boltless.me submitted #9
diff interdiff
1 commit
expand
21e8d9ec
appview/notify: pass logger with mergedLogger
expand 0 comments
pull request successfully merged
boltless.me submitted #8
diff interdiff
1 commit
expand
575a9958
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #7
diff
1 commit
expand
a89f3ff2
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
53d11e27
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
7f2340cf
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
079494ce
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
079494ce
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
7a6d7b11
appview/notify: pass logger with mergedLogger
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
debfd60a
appview/notify: pass logger with mergedLogger
expand 2 comments
oppi.li

nice lgtm, i was considering add a "logger" notifier, separate from every other notifier.

boltless.me

Each notifiers will need their own separate logs, so I think it would be better to let them call logger individually. For example, in same NewIssue event, one notifier might need to log the failure while all other notifiers worked fine.

boltless.me submitted #0
diff
1 commit
expand
c9316668
appview/notify: pass logger with mergedLogger
expand 0 comments