Monorepo for Tangled tangled.org

appview: improve patch validation #670

merged opened by oppi.li targeting master from push-sknqtnunznmn

automatically adds a newline to patches that are missing one.

Signed-off-by: oppiliappan me@oppi.li

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3m37vizubmi22
+2 -2
Interdiff #0 #1
appview/pulls/pulls.go

This file has not been changed.

appview/state/router.go

This file has not been changed.

appview/validator/patch.go

This file has not been changed.

knotserver/xrpc/merge_check.go

This file has not been changed.

patchutil/patchutil.go

This file has not been changed.

+2 -2
patchutil/patchutil_test.go
··· 106 106 just some 107 107 random text 108 108 that isn't a patch`, 109 - expected: EmptyPatchError, 109 + expected: GenericPatchError, 110 110 }, 111 111 } 112 112 113 113 for _, tt := range tests { 114 114 t.Run(tt.name, func(t *testing.T) { 115 115 result := IsPatchValid(tt.patch) 116 - if errors.Is(result, tt.expected) { 116 + if !errors.Is(result, tt.expected) { 117 117 t.Errorf("IsPatchValid() = %v, want %v", result, tt.expected) 118 118 } 119 119 })

History

2 rounds 0 comments
sign up or login to add to the discussion
oppi.li submitted #1
1 commit
expand
appview: improve patch validation
expand 0 comments
pull request successfully merged
oppi.li submitted #0
1 commit
expand
appview: improve patch validation
expand 0 comments