quilling.dev
An ATproto social media client -- with an independent Appview.
[🐴] Clean up after deleting message (#3950)
* Clean up after removal
* Remove console
authored by
Eric Bailey
and committed by
GitHub
d7f3a8d0
54c4baac
+2
src/state/messages/__tests__/convo.test.ts
+2
src/state/messages/__tests__/convo.test.ts
···
35
35
it.todo(
36
36
`successfully sent messages are re-ordered, if needed, by events received from server`,
37
37
)
38
+
it.todo(`pending messages are cleaned up from state after firehose event`)
38
39
})
39
40
40
41
describe(`deleting messages`, () => {
41
42
it.todo(`messages are optimistically deleted from the chat`)
42
43
it.todo(`messages are confirmed deleted via events from the server`)
44
+
it.todo(`deleted messages are cleaned up from state after firehose event`)
43
45
})
44
46
45
47
describe(`log handling`, () => {
+4
-8
src/state/messages/convo/agent.ts
+4
-8
src/state/messages/convo/agent.ts
···
678
678
/*
679
679
* Update if we have this in state. If we don't, don't worry about it.
680
680
*/
681
-
// TODO check for other storage spots
682
-
if (this.pastMessages.has(ev.message.id)) {
683
-
/*
684
-
* For now, we remove deleted messages from the thread, if we receive one.
685
-
*
686
-
* To support them, it'd look something like this:
687
-
* this.pastMessages.set(ev.message.id, ev.message)
688
-
*/
681
+
if (
682
+
this.pastMessages.has(ev.message.id) ||
683
+
this.newMessages.has(ev.message.id)
684
+
) {
689
685
this.pastMessages.delete(ev.message.id)
690
686
this.newMessages.delete(ev.message.id)
691
687
this.deletedMessages.delete(ev.message.id)