Pop-up dictionary browser extension for language learning. Successor to Yomichan. (PERSONAL FORK)

Clean up settings sidebar items (#2288)

* Fix ordering of dictionaries sidebar anchor link

* Fix transparent25 having 50% transparency

* Put advanced line next to advanced settings category

authored by

Kuuuube and committed by
GitHub
c24d4c9b e5388c26

+20 -3
+19 -2
ext/css/settings.css
··· 70 70 --content-dimmer-color: rgba(0, 0, 0, 0.1); 71 71 --advanced-color: #6640be; 72 72 --advanced-color-lighter: hsl(258, 50%, 75%); 73 - --advanced-color-transparent25: rgba(102, 64, 190, 0.5); 73 + --advanced-color-transparent50: rgba(102, 64, 190, 0.5); 74 74 75 75 --modal-padding-horizontal: 1em; 76 76 --modal-padding-vertical: 0.625em; ··· 456 456 cursor: pointer; 457 457 transition: background-color var(--animation-duration) ease-in-out; 458 458 box-sizing: border-box; 459 + position: relative; 459 460 } 460 461 .outline-item, 461 462 .outline-item:hover { ··· 760 761 height: 100%; 761 762 width: 0.25em; 762 763 } 764 + .outline-item.advanced-only::after { 765 + content: ''; 766 + background-color: var(--advanced-color-lighter); 767 + position: absolute; 768 + left: 0; 769 + height: 100%; 770 + width: 0.25em; 771 + } 763 772 .advanced-toggle { 764 773 --accent-color: var(--advanced-color); 765 774 --accent-color-lighter: var(--advanced-color-lighter); 766 - --accent-color-transparent25: var(--advanced-color-transparent25); 775 + --accent-color-transparent25: var(--advanced-color-transparent50); 767 776 } 768 777 769 778 /* Debug settings */ ··· 774 783 position: absolute; 775 784 right: 0; 776 785 top: 0; 786 + height: 100%; 787 + width: 0.25em; 788 + } 789 + .outline-item.debug-only::after { 790 + content: ''; 791 + background-color: var(--danger-color-lighter); 792 + position: absolute; 793 + left: 0; 777 794 height: 100%; 778 795 width: 0.25em; 779 796 }
+1 -1
ext/settings.html
··· 25 25 <div class="sidebar"><div class="sidebar-inner scrollbar"> 26 26 <div class="sidebar-body"> 27 27 <a href="#profile" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="profile"></span></span><span class="outline-item-label">Profile</span></a> 28 - <a href="#dictionaries" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="book"></span><span class="outline-item-left-warning-badge no-dictionaries-enabled-warning" hidden><div class="badge warning-badge"><span class="icon" data-icon="exclamation-point-short"></span></div></span></span><span class="outline-item-label">Dictionaries</span></a> 29 28 <a href="#general" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="cog"></span></span><span class="outline-item-label">General</span></a> 29 + <a href="#dictionaries" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="book"></span><span class="outline-item-left-warning-badge no-dictionaries-enabled-warning" hidden><div class="badge warning-badge"><span class="icon" data-icon="exclamation-point-short"></span></div></span></span><span class="outline-item-label">Dictionaries</span></a> 30 30 <a href="#scanning" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="scanning"></span></span><span class="outline-item-label">Scanning</span></a> 31 31 <a href="#popup" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="popup"></span></span><span class="outline-item-label">Popup Behavior</span></a> 32 32 <a href="#appearance" class="button outline-item"><span class="outline-item-left"><span class="outline-item-icon icon" data-icon="palette"></span></span><span class="outline-item-label">Appearance</span></a>