matrixfurry.com
The open source OpenXR runtime
a/vk: Add/update comments
Part-of: <https://gitlab.freedesktop.org/monado/monado/-/merge_requests/2332>
+14
-7
+14
-7
src/xrt/auxiliary/vk/vk_helpers.c
+14
-7
src/xrt/auxiliary/vk/vk_helpers.c
···
1063
1063
return ret;
1064
1064
}
1065
1065
1066
+
// - vk_csci_get_image_external_handle_type (usually but not always a constant)
1067
+
// - vk_csci_get_image_external_support
1068
+
// - vkGetPhysicalDeviceImageFormatProperties2
1069
+
// - vkCreateImage
1070
+
// - vkGetImageMemoryRequirements
1071
+
// - maybe vkGetAndroidHardwareBufferPropertiesANDROID
1072
+
// - vk_alloc_and_bind_image_memory
1066
1073
XRT_CHECK_RESULT VkResult
1067
1074
vk_create_image_from_native(struct vk_bundle *vk,
1068
1075
const struct xrt_swapchain_create_info *info,
···
1078
1085
#ifdef XRT_GRAPHICS_BUFFER_HANDLE_IS_AHARDWAREBUFFER
1079
1086
/*
1080
1087
* Some Vulkan drivers will natively support importing and exporting
1081
-
* SRGB formats (Qualcomm Adreno) even tho technically that's not intended
1082
-
* by the AHardwareBuffer since they don't support sRGB formats.
1083
-
* While others (arm Mali) does not support importing and exporting sRGB
1084
-
* formats. So we need to create the image without sRGB and then create
1085
-
* the image views with sRGB which is allowed by the Vulkan spec. It
1086
-
* seems to be safe to do with on all drivers, so to reduce the logic
1087
-
* do that instead.
1088
+
* SRGB formats (Qualcomm Adreno) even though technically the
1089
+
* AHardwareBuffer support for sRGB is... awkward (not inherent).
1090
+
* While others (arm Mali) does not support importing and exporting
1091
+
* sRGB formats. So we need to create the image without sRGB and
1092
+
* then create the image views with sRGB which is allowed by the
1093
+
* Vulkan spec. It seems to be safe to do with on all drivers,
1094
+
* so to reduce the logic do that instead.
1088
1095
*/
1089
1096
if (image_format == VK_FORMAT_R8G8B8A8_SRGB) {
1090
1097
image_format = VK_FORMAT_R8G8B8A8_UNORM;