malpercio.dev / ezpds
An easy-to-host PDS on the ATProtocol, MacOS. Grandma-approved.
fork atom

fix(MM-143): address Phase 2 code review feedback

- Issue 1 [Critical]: Add @types/node to devDependencies in apps/identity-wallet/package.json to fix 45 svelte-check type errors. Updated to ^22, reinstalled, verified svelte-check passes with 0 errors.
- Issue 2 [Important]: Add pnpm, cargo-tauri, and nodejs_22 to devenv.nix packages list. Phase 3 planned these additions; added early to unblock Phase 2's tauri.conf.json beforeDevCommand/beforeBuildCommand.
- Issue 3 [Minor]: Comment out [profile.release] block in apps/identity-wallet/src-tauri/Cargo.toml to suppress Cargo warning about profiles in non-root workspace packages. Preserved as documentation per design plan.

authored by malpercio.dev and committed by

Tangled 3c849eb5 6c8c9995

+8 -4
+1
apps/identity-wallet/package.json
··· 17 17 "@sveltejs/adapter-static": "^3.0.8", 18 18 "@sveltejs/kit": "^2.20.4", 19 19 "@sveltejs/vite-plugin-svelte": "^5.0.3", 20 + "@types/node": "^22", 20 21 "svelte": "^5.25.8", 21 22 "svelte-check": "^4.1.5", 22 23 "tslib": "^2.8.1",
+4 -4
apps/identity-wallet/src-tauri/Cargo.toml
··· 29 29 # They are included per the design plan as documentation of Tauri's recommendations. 30 30 # When iOS release binary size becomes a concern, move these to the root Cargo.toml's 31 31 # [profile.release] section (note: that will affect ALL workspace crates' release builds). 32 - [profile.release] 33 - strip = true 34 - lto = true 35 - opt-level = "z" 32 + # [profile.release] 33 + # strip = true 34 + # lto = true 35 + # opt-level = "z"
+3
devenv.nix
··· 10 10 pkgs.cargo-audit 11 11 pkgs.sqlite 12 12 pkgs.pkg-config 13 + pkgs.cargo-tauri 14 + pkgs.nodejs_22 15 + pkgs.pnpm 13 16 ]; 14 17 15 18 env.LIBSQLITE3_SYS_USE_PKG_CONFIG = "1";