+1 -1

lib/skyfall/firehose/account_message.rb

··· 24 # 25 def initialize(type_object, data_object) 26 super 27 - check_if_not_nil %w(seq did time active) 28 29 @active = @data_object['active'] 30 @status = @data_object['status']&.to_sym

··· 24 # 25 def initialize(type_object, data_object) 26 super 27 + check_if_not_nil 'seq', 'did', 'time', 'active' 28 29 @active = @data_object['active'] 30 @status = @data_object['status']&.to_sym

+1 -1

lib/skyfall/firehose/commit_message.rb

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 - check_if_not_nil %w(seq repo commit blocks ops time) 30 end 31 32 # @return [CID] CID (Content Identifier) of the commit

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 + check_if_not_nil 'seq', 'repo', 'commit', 'blocks', 'ops', 'time' 30 end 31 32 # @return [CID] CID (Content Identifier) of the commit

+1 -1

lib/skyfall/firehose/identity_message.rb

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 - check_if_not_nil %w(seq did time) 30 31 @handle = @data_object['handle'] 32 end

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 + check_if_not_nil 'seq', 'did', 'time' 30 31 @handle = @data_object['handle'] 32 end

+1 -1

lib/skyfall/firehose/info_message.rb

··· 37 # 38 def initialize(type_object, data_object) 39 super 40 - check_if_not_nil %w(name) 41 42 @name = @data_object['name'] 43 @message = @data_object['message']

··· 37 # 38 def initialize(type_object, data_object) 39 super 40 + check_if_not_nil 'name' 41 42 @name = @data_object['name'] 43 @message = @data_object['message']

+1 -1

lib/skyfall/firehose/labels_message.rb

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 - check_if_not_nil %w(seq labels) 30 31 @labels = @data_object['labels'].map { |x| Label.new(x) } 32 end

··· 26 # 27 def initialize(type_object, data_object) 28 super 29 + check_if_not_nil 'seq', 'labels' 30 31 @labels = @data_object['labels'].map { |x| Label.new(x) } 32 end

+15 -8

lib/skyfall/firehose/message.rb

··· 152 instance_variables - [:@type_object, :@data_object, :@blocks] 153 end 154 155 - # Checks if all required fields are set in the data object. 156 - # @param fields [Array<String>] list of fields to check 157 - # @raise [DecodeError] if any of the fields is nil or not set 158 - def check_if_not_nil(fields) 159 - missing = fields.select { |f| @data_object[f].nil? } 160 161 - raise DecodeError.new("Missing event details (#{missing.map(&:to_s).join(', ')})") if missing.length > 0 162 - end 163 0 0 0 0 0 0 0 0 164 165 - private 0 0 0 0 0 166 167 def self.decode_cbor_objects(data) 168 objects = CBOR.decode_sequence(data)

··· 152 instance_variables - [:@type_object, :@data_object, :@blocks] 153 end 154 0 0 0 0 0 155 156 + private 0 157 158 + # Note: this method is written this way as an optimization 159 + def check_if_not_nil(a, b = nil, c = nil, d = nil, e = nil, f = nil) 160 + ok = @data_object.has_key?(a) 161 + ok &&= @data_object.has_key?(b) if b 162 + ok &&= @data_object.has_key?(c) if c 163 + ok &&= @data_object.has_key?(d) if d 164 + ok &&= @data_object.has_key?(e) if e 165 + ok &&= @data_object.has_key?(f) if f 166 167 + if !ok 168 + expected_fields = [a, b, c, d, e, f].compact 169 + missing_fields = expected_fields.select { |x| @data_object[x].nil? } 170 + raise DecodeError.new("Missing event details (#{missing_fields.map(&:to_s).join(', ')})") 171 + end 172 + end 173 174 def self.decode_cbor_objects(data) 175 objects = CBOR.decode_sequence(data)