lewis.moe
Monorepo for Tangled
appview/pages: finesse pull review page styles
- transparent blue caused text ovelaps
- mobile view hide the split/unified buttons
- transparent topbar caused text overlaps
Signed-off-by: oppiliappan <me@oppi.li>
+3
-5
appview/pages/templates/repo/fragments/diff.html
+3
-5
appview/pages/templates/repo/fragments/diff.html
···
23
23
{{ block "subsCheckbox" $ }} {{ end }}
24
24
25
25
<!-- top bar -->
26
-
<div class="sticky top-0 z-30 flex items-center gap-2 col-span-full h-12 p-2 {{ if $root }}mt-4{{ end }}">
26
+
<div class="sticky top-0 z-30 bg-slate-100 dark:bg-gray-900 flex items-center gap-2 col-span-full h-12 p-2 {{ if $root }}mt-4{{ end }}">
27
27
<!-- left panel toggle -->
28
28
{{ template "filesToggle" . }}
29
29
···
31
31
{{ $stat := $diff.Stats }}
32
32
{{ $count := len $diff.ChangedFiles }}
33
33
{{ template "repo/fragments/diffStatPill" $stat }}
34
-
<span class="text-xs text-gray-600 dark:text-gray-400">{{ $count }} changed file{{ if ne $count 1 }}s{{ end }}</span>
34
+
<span class="text-xs text-gray-600 dark:text-gray-400 hidden md:inline-flex">{{ $count }} changed file{{ if ne $count 1 }}s{{ end }}</span>
35
35
36
36
{{ if $root }}
37
37
{{ if $root.IsInterdiff }}
···
70
70
{{ template "collapseToggle" }}
71
71
72
72
<!-- diff options -->
73
-
<div class="hidden md:block">
74
-
{{ template "repo/fragments/diffOpts" $opts }}
75
-
</div>
73
+
{{ template "repo/fragments/diffOpts" $opts }}
76
74
77
75
<!-- right panel toggle -->
78
76
{{ block "subsToggle" $ }} {{ end }}
+10
-2
appview/pages/templates/repo/pulls/pull.html
+10
-2
appview/pages/templates/repo/pulls/pull.html
···
246
246
{{ $lastIdx := index . 2 }}
247
247
{{ $root := index . 3 }}
248
248
{{ $round := $item.RoundNumber }}
249
-
<div class="{{ if eq $round 0 }}rounded-b{{ else }}rounded{{ end }} px-6 py-4 pr-2 pt-2 {{ if eq $root.ActiveRound $round }}bg-blue-100 dark:bg-blue-900/50 border-b border-blue-200 dark:border-blue-700{{ else }}bg-white dark:bg-gray-800 border-b border-gray-200 dark:border-gray-700{{ end }} flex gap-2 sticky top-0 z-20">
249
+
<div class="
250
+
{{ if eq $round 0 }}rounded-b{{ else }}rounded{{ end }}
251
+
px-6 py-4 pr-2 pt-2
252
+
{{ if eq $root.ActiveRound $round }}
253
+
bg-blue-100 dark:bg-blue-900 border-b border-blue-200 dark:border-blue-700
254
+
{{ else }}
255
+
bg-white dark:bg-gray-800 border-b border-gray-200 dark:border-gray-700
256
+
{{ end }}
257
+
flex gap-2 sticky top-0 z-20">
250
258
<!-- left column: just profile picture -->
251
259
<div class="flex-shrink-0 pt-2">
252
260
<img
···
286
294
<div class="flex gap-2 items-center">
287
295
{{ if ne $root.ActiveRound $round }}
288
296
<a class="btn-flat flex items-center gap-2 no-underline hover:no-underline text-sm"
289
-
href="/{{ $root.RepoInfo.FullName }}/pulls/{{ $root.Pull.PullId }}/round/{{ $round }}?{{ safeUrl $root.DiffOpts.Encode }}">
297
+
href="/{{ $root.RepoInfo.FullName }}/pulls/{{ $root.Pull.PullId }}/round/{{ $round }}?{{ safeUrl $root.DiffOpts.Encode }}#round-#{{ $round }}">
290
298
{{ i "diff" "w-4 h-4" }}
291
299
diff
292
300
</a>