jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

target/ppc: remove unnecessary if() around calls to set_dfp{64,128}() in DFP macros

Now that the parameters to both set_dfp64() and set_dfp128() are exactly the
same, there is no need for an explicit if() statement to determine which
function should be called based upon size. Instead we can simply use the
preprocessor to generate the call to set_dfp##size() directly.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190926185801.11176-8-mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

authored by

Mark Cave-Ayland and committed by
David Gibson f6d4c423 1ea80bf7

+10 -50
+10 -50
target/ppc/dfp_helper.c
··· 427 427 dnop(&dfp.t, &dfp.a, &dfp.b, &dfp.context); \ 428 428 dfp_finalize_decimal##size(&dfp); \ 429 429 postprocs(&dfp); \ 430 - if (size == 64) { \ 431 - set_dfp64(t, &dfp.vt); \ 432 - } else if (size == 128) { \ 433 - set_dfp128(t, &dfp.vt); \ 434 - } \ 430 + set_dfp##size(t, &dfp.vt); \ 435 431 } 436 432 437 433 static void ADD_PPs(struct PPC_DFP *dfp) ··· 747 743 dfp_finalize_decimal##size(&dfp); \ 748 744 QUA_PPs(&dfp); \ 749 745 \ 750 - if (size == 64) { \ 751 - set_dfp64(t, &dfp.vt); \ 752 - } else if (size == 128) { \ 753 - set_dfp128(t, &dfp.vt); \ 754 - } \ 746 + set_dfp##size(t, &dfp.vt); \ 755 747 } 756 748 757 749 DFP_HELPER_QUAI(dquai, 64) ··· 769 761 dfp_finalize_decimal##size(&dfp); \ 770 762 QUA_PPs(&dfp); \ 771 763 \ 772 - if (size == 64) { \ 773 - set_dfp64(t, &dfp.vt); \ 774 - } else if (size == 128) { \ 775 - set_dfp128(t, &dfp.vt); \ 776 - } \ 764 + set_dfp##size(t, &dfp.vt); \ 777 765 } 778 766 779 767 DFP_HELPER_QUA(dqua, 64) ··· 851 839 dfp_finalize_decimal##size(&dfp); \ 852 840 QUA_PPs(&dfp); \ 853 841 \ 854 - if (size == 64) { \ 855 - set_dfp64(t, &dfp.vt); \ 856 - } else if (size == 128) { \ 857 - set_dfp128(t, &dfp.vt); \ 858 - } \ 842 + set_dfp##size(t, &dfp.vt); \ 859 843 } 860 844 861 845 DFP_HELPER_RRND(drrnd, 64) ··· 874 858 dfp_finalize_decimal##size(&dfp); \ 875 859 postprocs(&dfp); \ 876 860 \ 877 - if (size == 64) { \ 878 - set_dfp64(t, &dfp.vt); \ 879 - } else if (size == 128) { \ 880 - set_dfp128(t, &dfp.vt); \ 881 - } \ 861 + set_dfp##size(t, &dfp.vt); \ 882 862 } 883 863 884 864 static void RINTX_PPs(struct PPC_DFP *dfp) ··· 978 958 dfp_finalize_decimal##size(&dfp); \ 979 959 CFFIX_PPs(&dfp); \ 980 960 \ 981 - if (size == 64) { \ 982 - set_dfp64(t, &dfp.vt); \ 983 - } else if (size == 128) { \ 984 - set_dfp128(t, &dfp.vt); \ 985 - } \ 961 + set_dfp##size(t, &dfp.vt); \ 986 962 } 987 963 988 964 static void CFFIX_PPs(struct PPC_DFP *dfp) ··· 1088 1064 dfp_set_sign_##size(&dfp.vt, sgn); \ 1089 1065 } \ 1090 1066 \ 1091 - if (size == 64) { \ 1092 - set_dfp64(t, &dfp.vt); \ 1093 - } else if (size == 128) { \ 1094 - set_dfp128(t, &dfp.vt); \ 1095 - } \ 1067 + set_dfp##size(t, &dfp.vt); \ 1096 1068 } 1097 1069 1098 1070 DFP_HELPER_DEDPD(ddedpd, 64) ··· 1160 1132 } \ 1161 1133 dfp_finalize_decimal##size(&dfp); \ 1162 1134 dfp_set_FPRF_from_FRT(&dfp); \ 1163 - if ((size) == 64) { \ 1164 - set_dfp64(t, &dfp.vt); \ 1165 - } else if ((size) == 128) { \ 1166 - set_dfp128(t, &dfp.vt); \ 1167 - } \ 1135 + set_dfp##size(t, &dfp.vt); \ 1168 1136 } 1169 1137 1170 1138 DFP_HELPER_ENBCD(denbcd, 64) ··· 1264 1232 dfp.t.exponent = exp - bias; \ 1265 1233 dfp_finalize_decimal##size(&dfp); \ 1266 1234 } \ 1267 - if (size == 64) { \ 1268 - set_dfp64(t, &dfp.vt); \ 1269 - } else if (size == 128) { \ 1270 - set_dfp128(t, &dfp.vt); \ 1271 - } \ 1235 + set_dfp##size(t, &dfp.vt); \ 1272 1236 } 1273 1237 1274 1238 DFP_HELPER_IEX(diex, 64) ··· 1356 1320 } \ 1357 1321 } \ 1358 1322 \ 1359 - if ((size) == 64) { \ 1360 - set_dfp64(t, &dfp.vt); \ 1361 - } else { \ 1362 - set_dfp128(t, &dfp.vt); \ 1363 - } \ 1323 + set_dfp##size(t, &dfp.vt); \ 1364 1324 } 1365 1325 1366 1326 DFP_HELPER_SHIFT(dscli, 64, 1)