jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

tests: qdev_prop_check_globals() doesn't return "all_used"

Instead, it returns 1 if an error was detected, which is the case for:

/qdev/properties/dynamic/global/subprocess:
warning: global dynamic-prop-type-bad.prop3 has invalid class name
warning: global nohotplug-type.prop5=105 not used
warning: global nondevice-type.prop6 has invalid class name

Clarify the function return value.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20181204142023.15982-2-marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

authored by

Marc-André Lureau and committed by
Eduardo Habkost ef240523 112394af

+6 -6
+6 -6
tests/test-qdev-global-props.c
··· 214 214 { TYPE_NONDEVICE, "prop6", "106", true }, 215 215 {} 216 216 }; 217 - int all_used; 217 + int global_error; 218 218 219 219 qdev_prop_register_global_list(props); 220 220 ··· 223 223 224 224 g_assert_cmpuint(mt->prop1, ==, 101); 225 225 g_assert_cmpuint(mt->prop2, ==, 102); 226 - all_used = qdev_prop_check_globals(); 227 - g_assert_cmpuint(all_used, ==, 1); 226 + global_error = qdev_prop_check_globals(); 227 + g_assert_cmpuint(global_error, ==, 1); 228 228 g_assert(props[0].used); 229 229 g_assert(props[1].used); 230 230 g_assert(!props[2].used); ··· 259 259 { TYPE_NONDEVICE, "prop6", "106" }, 260 260 {} 261 261 }; 262 - int all_used; 262 + int global_error; 263 263 264 264 qdev_prop_register_global_list(props); 265 265 ··· 268 268 269 269 g_assert_cmpuint(mt->prop1, ==, 101); 270 270 g_assert_cmpuint(mt->prop2, ==, 102); 271 - all_used = qdev_prop_check_globals(); 272 - g_assert_cmpuint(all_used, ==, 0); 271 + global_error = qdev_prop_check_globals(); 272 + g_assert_cmpuint(global_error, ==, 0); 273 273 g_assert(props[0].used); 274 274 g_assert(props[1].used); 275 275 g_assert(!props[2].used);