jcs.org / qemu
qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio
fork atom

linux-user: Remove dead error-checking code

Remove some dead code spotted by Coverity (CID 1009855,
1390854, 1390847). The underlying cause in all these cases
is the same: QEMU's put_user operations can't result in
errors, but the kernel's equivalent does. So when code
was copied from the kernel signal-frame-setup/teardown
code, checks on error flags that were needed in the kernel
became dead code for us.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20181019161715.12122-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>

authored by

Peter Maydell and committed by
Laurent Vivier e285977e b4c05954

-9
-3
linux-user/m68k/signal.c
··· 334 334 (uint32_t *)(frame->retcode + 0)); 335 335 __put_user(0x4e40, (uint16_t *)(frame->retcode + 4)); 336 336 337 - if (err) 338 - goto give_sigsegv; 339 - 340 337 /* Set up to return from userspace */ 341 338 342 339 env->aregs[7] = frame_addr;
-4
linux-user/sh4/signal.c
··· 279 279 sigset_t blocked; 280 280 target_sigset_t target_set; 281 281 int i; 282 - int err = 0; 283 282 284 283 frame_addr = regs->gregs[15]; 285 284 trace_user_do_sigreturn(regs, frame_addr); ··· 291 290 for(i = 1; i < TARGET_NSIG_WORDS; i++) { 292 291 __get_user(target_set.sig[i], &frame->extramask[i - 1]); 293 292 } 294 - 295 - if (err) 296 - goto badframe; 297 293 298 294 target_to_host_sigset_internal(&blocked, &target_set); 299 295 set_sigmask(&blocked);
-2
linux-user/sparc/signal.c
··· 256 256 /* t 0x10 */ 257 257 val32 = 0x91d02010; 258 258 __put_user(val32, &sf->insns[1]); 259 - if (err) 260 - goto sigsegv; 261 259 } 262 260 unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); 263 261 return;