qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

block/replication: Remove protocol_name field

The protocol_name field is used when selecting a driver via protocol
syntax (i.e. <protocol_name>:<filename:options:...>). Drivers that are
only selected explicitly (e.g. driver=replication,mode=primary,...)
should not have a protocol_name.

This patch removes the protocol_name field from the brdv_replication
structure so that attempts to invoke this driver using protocol syntax
will fail gracefully:

$ qemu-img info replication:foo
qemu-img: Could not open 'replication:': Unknown protocol 'replication'

Buglink: https://bugs.launchpad.net/qemu/+bug/1726733
Signed-off-by: Fabiano Rosas <farosas@linux.vnet.ibm.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

authored by

Fabiano Rosas and committed by
Kevin Wolf
cb83d2ef 71b74b25

-2
-1
block/replication.c
··· 703 703 704 704 BlockDriver bdrv_replication = { 705 705 .format_name = "replication", 706 - .protocol_name = "replication", 707 706 .instance_size = sizeof(BDRVReplicationState), 708 707 709 708 .bdrv_open = replication_open,
-1
replication.h
··· 67 67 * 68 68 * BlockDriver bdrv_replication = { 69 69 * .format_name = "replication", 70 - * .protocol_name = "replication", 71 70 * .instance_size = sizeof(BDRVReplicationState), 72 71 * 73 72 * .bdrv_open = replication_open,