jcs.org
qemu with hax to log dma reads & writes
jcs.org/2018/11/12/vfio
sd/milkymist-memcard: Plug minor memory leak in realize
milkymist_memcard_realize() leaks an Error object when realization of
its "sd-card" device fails. Quite harmless, since we only ever
realize this once, in milkymist_init() via milkymist_memcard_create().
Plug the leak.
Fixes: 3d0369ba499866cc6a839f71212d97876500762d
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Michael Walle <michael@walle.cc>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
+2
-3
+2
-3
hw/sd/milkymist-memcard.c
+2
-3
hw/sd/milkymist-memcard.c
···
280
280
blk = dinfo ? blk_by_legacy_dinfo(dinfo) : NULL;
281
281
carddev = qdev_new(TYPE_SD_CARD);
282
282
qdev_prop_set_drive(carddev, "drive", blk);
283
-
qdev_realize_and_unref(carddev, BUS(&s->sdbus), &err);
284
-
if (err) {
285
-
error_setg(errp, "failed to init SD card: %s", error_get_pretty(err));
283
+
if (!qdev_realize_and_unref(carddev, BUS(&s->sdbus), &err)) {
284
+
error_propagate_prepend(errp, err, "failed to init SD card: %s");
286
285
return;
287
286
}
288
287
s->enabled = blk && blk_is_inserted(blk);