net/eth: fix incorrect check of iov_to_buf() return value

qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

So we have sizeof(struct in6_address) != sizeof(uintptr_t)
and Clang > Coverity on this, see 4555ca6816c :)

net/eth.c:426:30: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(dst_addr);
^ ~~~~~~~~~~
net/eth.c:475:34: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(src_addr);
^ ~~~~~~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

authored by

Philippe Mathieu-Daudé and committed by

Michael Tokarev 8 years ago b2caa3b8 9f26f325

+2 -2

1 changed file

expand all

net

eth.c

+2 -2

net/eth.c

··· 423 423 rthdr_offset + sizeof(*ext_hdr), 424 424 dst_addr, sizeof(*dst_addr)); 425 425 426 - return bytes_read == sizeof(dst_addr); 426 + return bytes_read == sizeof(*dst_addr); 427 427 } 428 428 429 429 return false; ··· 472 472 opt_offset + sizeof(opthdr), 473 473 src_addr, sizeof(*src_addr)); 474 474 475 - return bytes_read == sizeof(src_addr); 475 + return bytes_read == sizeof(*src_addr); 476 476 } 477 477 478 478 opt_offset += optlen;