hw/misc/vmcoreinfo: Add comment about reset handler

qemu with hax to log dma reads & writes jcs.org/2018/11/12/vfio

The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().

Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010131527.32513-9-philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

authored by

Philippe Mathieu-Daudé and committed by

Eduardo Habkost 6 years ago 88552b16 f7030d00

1 changed file

expand all

misc

vmcoreinfo.c

hw/misc/vmcoreinfo.c

··· 61 61 NULL, fw_cfg_vmci_write, s, 62 62 &s->vmcoreinfo, sizeof(s->vmcoreinfo), false); 63 63 64 + /* 65 + * This device requires to register a global reset because it is 66 + * not plugged to a bus (which, as its QOM parent, would reset it). 67 + */ 64 68 qemu_register_reset(vmcoreinfo_reset, dev); 65 69 vmcoreinfo_state = s; 66 70 }